[action] [PR:9048] test_radv_ipv6_ra is unnecessarily skipped on non-dualtor topology#9299
Merged
mssonicbld merged 1 commit intosonic-net:202305from Aug 4, 2023
Merged
Conversation
…onic-net#9048) What is the motivation for this PR? Script test_radv_ipv6_ra.py is unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixture toggle_all_simulator_ports_to_upper_tor which depends on cable_type fixture. The cable_type fixture requires that the topology must has "dualtor", otherwise skip the test. How did you do it? This change updated the test_radv_ipv6_ra.py to use fixture toggle_all_simulator_ports_to_random_side. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
6 tasks
Collaborator
Author
|
Original PR: #9048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Script
test_radv_ipv6_ra.pyis unnecessarily skipped on non-dualtor topology. The reason is that this script uses fixturetoggle_all_simulator_ports_to_upper_torwhich depends oncable_typefixture.The
cable_typefixture requires that the topology must has "dualtor", otherwise skip the test.How did you do it?
This change updated the
test_radv_ipv6_ra.pyto use fixturetoggle_all_simulator_ports_to_random_side.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation