[continuous_link_flap.yml]: Continuous link flap test.#810
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Jul 8, 2019
Merged
[continuous_link_flap.yml]: Continuous link flap test.#810qiluo-msft merged 4 commits intosonic-net:masterfrom
qiluo-msft merged 4 commits intosonic-net:masterfrom
Conversation
This is continuous link flap test. In this test, 1.) Flap all interfaces one by one to cause BGP Flaps (3 iterations). 2.) Flap all interfaces on peer (FanOutLeaf) one by one to cause BGP Flaps (3 iterations). 3.) Watch for memory (show system-memory) ,orchagent CPU Utilization and Redis_memory. Pass Criteria: All routes must be re-learned with < 5% increase in Redis memory and with Orchagent CPU consumption below 10% after 3 mins of stopping flaps. Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
Member
Author
|
Kindly review, Let me know if any issue. |
qiluo-msft
reviewed
Apr 10, 2019
qiluo-msft
reviewed
Apr 10, 2019
qiluo-msft
reviewed
Apr 10, 2019
qiluo-msft
reviewed
Apr 10, 2019
qiluo-msft
reviewed
Apr 10, 2019
qiluo-msft
reviewed
Apr 10, 2019
qiluo-msft
reviewed
Apr 10, 2019
ansible/roles/test/tasks/continuous_link_flap/continuous_link_flap_helper.yml
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Apr 10, 2019
ansible/roles/test/tasks/continuous_link_flap/continuous_link_flap_helper.yml
Outdated
Show resolved
Hide resolved
added 2 commits
April 11, 2019 01:04
Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
[testcases.yml]: run only on t1 to bring l3 interfaces down. Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
Member
Author
|
Address all review comments, kindly review. Thx. |
qiluo-msft
reviewed
Apr 24, 2019
qiluo-msft
reviewed
Apr 24, 2019
…k flap test. Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
qiluo-msft
reviewed
Apr 27, 2019
Contributor
|
I heard the purpose of this test case is to identify unexpected memory increase during link flap. How can I know if it happens or not? |
Member
Author
We are watching redis db memory at start and end of the test. If it increases by 5% or more then test case fails. |
Member
Author
|
Kindly review and merge if we are still writing new tests in Ansible :). Thanks a lot. |
zhenggen-xu
approved these changes
Jul 8, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is continuous link flap test. In this test,
1.) Flap all interfaces one by one to cause BGP Flaps on DUT (3 iterations).
2.) Flap all interfaces on peer (FanOutLeaf) one by one to cause BGP Flaps (3 iterations).
3.) Watch for memory (show system-memory) ,orchagent CPU Utilization and Redis_memory.
Pass Criteria: All routes must be re-learned with < 5% increase in Redis memory
and with Orchagent CPU consumption below 10% after 90 secs of stopping flaps.
Signed-off-by: Praveen Chaudharypchaudhary@linkedin.com
Description of PR
[continuous_link_flap.yml]: Continuous link flap test.
This is a new test case to check Redis memory increase for link flaps.
Test also watches for orchagent cpu usage and system memory, but not necessary include them while deciding pass criteria.
Summary:
This is continuous link flap test. In this test,
1.) Flap all interfaces one by one to cause BGP Flaps on DUT (3 iterations).
2.) Flap all interfaces on peer (FanOutLeaf) one by one to cause BGP Flaps (3 iterations).
3.) Watch for memory (show system-memory) ,orchagent CPU Utilization and Redis_memory.
Fixes # (issue)
Type of change
Approach
How did you do it?
In this test:
First:
1.) I record Redis Memory and ipv4 routes at start.
2.) Make sure orchagent consuming then than 10% cpu before starting the test.
3.) I flap all interfaces one by one to cause BGP Flaps on DUT (3 iterations).
4.) then I flap all interfaces on peer (FanOutLeaf) one by one to cause BGP Flaps (3 iterations).
5.) Test continuously watches for memory (show system-memory) ,orchagent CPU Utilization and Redis_memory.
6.) At last compares Total Redis memory difference and ipv6 routes.
Pass Criteria is based on:
1.) All routes must be re-learned
2.) with < 5% increase in Redis memory
3.) and with Orchagent CPU consumption below 10% after 90 secs of stopping flaps.
How did you verify/test it?
Ran on T0 and T1.
On t0 Redis memory consumption is less.
On T1 Redis memory consumption increases by > 30%
Output Snippet:
Any platform specific information?
Supported testbed topology if it's a new test case?
Ran on T0 and T1.
Documentation