[Python3 migration]Fix test failure in test_nhop_group.py#8076
Merged
wsycqyz merged 1 commit intosonic-net:masterfrom Apr 19, 2023
Merged
[Python3 migration]Fix test failure in test_nhop_group.py#8076wsycqyz merged 1 commit intosonic-net:masterfrom
wsycqyz merged 1 commit intosonic-net:masterfrom
Conversation
jcaiMR
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes test failure after Python3 migration in test_nhop_group.py
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failed with following error:
File "/azp/_work/15/s/tests/ipfwd/test_nhop_group.py", line 117, in init
moff1 = "{0:x}".format(i / 255)
ValueError: Unknown format code 'x' for object of type 'float'
How did you do it?
Use "//" instead of "/"
Search the whole code base and only find this one.
How did you verify/test it?
Manually run the testcase.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation