Skip to content

Enhancing test_route_perf.py to add traffic verification#7686

Merged
wangxin merged 1 commit intosonic-net:masterfrom
kbabujp:sm_route
Mar 13, 2023
Merged

Enhancing test_route_perf.py to add traffic verification#7686
wangxin merged 1 commit intosonic-net:masterfrom
kbabujp:sm_route

Conversation

@kbabujp
Copy link
Copy Markdown
Contributor

@kbabujp kbabujp commented Mar 8, 2023

Description of PR

  • Adding traffic verification after the routes are installed.
  • Current verification done with APP DB commands.
  • Adding traffic verification and using different route prefix will harden the test
  • It will also ensure the routes are actually programmed on asic.

Summary:
Enhancing test_route_perf.py to add traffic verification

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Enhancing test_route_perf.py to add traffic verification

How did you do it?

How did you verify/test it?

Ran this test in T0, T1, M0 topo and it passed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/route/test_route_perf.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/route/test_route_perf.py:6:1: F401 'ipaddress' imported but unused
tests/route/test_route_perf.py:10:1: F401 'tests.common.dualtor.dual_tor_utils.get_t1_ptf_ports' imported but unused
tests/route/test_route_perf.py:12:1: F401 'tests.common.utilities.wait_until' imported but unused
tests/route/test_route_perf.py:51:1: E302 expected 2 blank lines, found 1
tests/route/test_route_perf.py:58:1: E302 expected 2 blank lines, found 1
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants