made possible to skip one of 2 similar warmboot test cases#7280
Open
antonptashnik wants to merge 1 commit intosonic-net:masterfrom
Open
made possible to skip one of 2 similar warmboot test cases#7280antonptashnik wants to merge 1 commit intosonic-net:masterfrom
antonptashnik wants to merge 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
@ZhaohuiS take a look please. Thanks in advance! |
ZhaohuiS
reviewed
Jan 28, 2023
| parser.addoption( | ||
| "--multi_sad_only", | ||
| action="store_true", | ||
| default=False |
Contributor
There was a problem hiding this comment.
Should set multi_sad_only default value to True?
Contributor
Author
There was a problem hiding this comment.
I left it as it is to avoid unexpected skips for others. Vendor needs decide himself and skip one of the suites explicitly
using any proposed flag, if he wants to, passing the corresponding flag at test run
vaibhavhd
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: made possible to skip one of 2 similar warmboot test cases
Fixes # (issue)
There are 2 warm-reboot TC sets for
test_warm_reboot_sadamong others: sad and multi-sad.Such a suite sets port/lag oper/admin state down before reboot and verifies its still down after reboot. The only difference between sad and multi_sad suites is the number of ports selected for the scenario - "sad" selects 1 port only while "multi_sad" selects 2-3.
To reduce test exec time we can skip just "sad" suite and run "multi_sad" suite only as it covers same scenario with more ports checked. Introduced corresponding flags that allow skipping sad/multi_sad test suite - "single_sad_only" and "multi_sad_only".
Type of change
Back port request
Approach
What is the motivation for this PR?
Allow one to reduce advanced tests exec time by skipping one of similar test suites
How did you do it?
Introduced flags for skipping a desired test
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation