Measure reboot start time by pinging DUT's vlan interface#694
Merged
lguohan merged 2 commits intosonic-net:masterfrom Sep 6, 2018
Merged
Measure reboot start time by pinging DUT's vlan interface#694lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
A device may do some additional work after executing "fast-reboot" in cli without CP/DP disruption Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
pavel-shirshov
suggested changes
Sep 4, 2018
|
|
||
| self.reboot_start = datetime.datetime.now() | ||
| self.log("Dut reboots: reboot start %s" % str(self.reboot_start)) | ||
|
|
Contributor
There was a problem hiding this comment.
I'd suggest to insert a check that the DUT data plane is still working.
Right after you found your control plane are rebooting, check that your DUT is able to send packets back and forth. And after that wait until DUT data plane is stopped working.
| self.check_param('min_bgp_gr_timeout', 15, required = False) | ||
|
|
||
| # Default settings | ||
| self.ping_dut_pkts = 100 |
Contributor
There was a problem hiding this comment.
I'd suggest to use lower value, like 10 or 20. We need higher values in the data plane tests because of requirements.
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
pavel-shirshov
approved these changes
Sep 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A device may do some additional work after executing
"fast-reboot" in cli without CP/DP disruption
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation