[tacacs] Config NOT ignore errors while test read-only allowed commands#3773
Closed
kevinskwang wants to merge 1 commit intosonic-net:masterfrom
Closed
[tacacs] Config NOT ignore errors while test read-only allowed commands#3773kevinskwang wants to merge 1 commit intosonic-net:masterfrom
kevinskwang wants to merge 1 commit intosonic-net:masterfrom
Conversation
What is the motivation for this PR? Currently, we ignore most of the errors except permission errors in the read-only command test cases of TACACS. That may lead to the test case can't detect some basic issues in the code. Especially in the kvm test which is the fundament PR test of sonic_mgmt. How did you do it? For the read-only allowed command, don't ignore any errors. How did you verify/test it? Run tacacs/test_ro_user.py::test_ro_user_allowed_command, the test case should pass. Signed-off-by: Kevin Wang <shengkaiwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
Currently, we ignore most of the errors except permission errors in the read-only command test cases of TACACS.
That may lead to the test case can't detect some basic issues in the code. Especially in the kvm test which is the fundament PR test of sonic_mgmt.
How did you do it?
For the read-only allowed command, don't ignore any errors.
How did you verify/test it?
Run tacacs/test_ro_user.py::test_ro_user_allowed_command, the test case should pass.
Signed-off-by: Kevin Wang shengkaiwang@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation