[conftest]: Enforce strict order for enhance_inventory fixture#2878
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jan 28, 2021
Merged
[conftest]: Enforce strict order for enhance_inventory fixture#2878wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
3 tasks
yxieca
approved these changes
Jan 27, 2021
Contributor
Author
|
retest vsimage please |
1 similar comment
Contributor
Author
|
retest vsimage please |
wangxin
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
It is possible for session level fixtures with
autouse=Trueto run beforeenhance_inventory. If this happens, and these fixtures are dependent on theduthostsfixture, inventory files may not be properly parsed.How did you do it?
Make
duthostsdependent onenhance_inventoryto make sure that inventory files are always properly parsed before attempting to initialize Ansible inventory.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation