Fix neighbor health check failure for dualToR#2833
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jan 19, 2021
wangxin:fix-dualtor-nbr-check
Merged
Fix neighbor health check failure for dualToR#2833yxieca merged 1 commit intosonic-net:masterfrom wangxin:fix-dualtor-nbr-check
yxieca merged 1 commit intosonic-net:masterfrom
wangxin:fix-dualtor-nbr-check
Conversation
PR #2792 introduced neighbor with type 'Server' into 'DEVICE_NEIGHBOR_METADATA' of config DB. The 'Server' neighbors should be skipped in neighbor health check. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
vaibhavhd
approved these changes
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
PR #2792 introduced neighbor with type 'Server' into 'DEVICE_NEIGHBOR_METADATA' of config DB.
The 'Server' neighbors should be skipped in neighbor health check.
How did you do it?
Skip checking neighbor with type 'Server'.
How did you verify/test it?
Test run the test_nbr_health.py script on dualtor. Test passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation