[action] [PR:19899] Fix saithrift URL generation for Mellanox on internal-202411 branch#19946
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jul 31, 2025
Merged
Conversation
…onic-net#19899 What is the motivation for this PR? The saithrift package download fails for Mellanox platforms on internal-202411 branch because the code was hardcoding bullseye as the Debian codename for all ASIC types, but Mellanox requires the actual Debian codename from the syncd container. How did you do it? Modified the condition to only use hardcoded bullseye for non-Mellanox platforms on internal-202411 For Mellanox on internal-202411, the code now retrieves the actual Debian codename via docker command This ensures the correct saithrift package URL is constructed for each platform type How did you verify/test it? local test
11 tasks
Collaborator
Author
|
Original PR: #19899 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The saithrift package download fails for Mellanox platforms on internal-202411 branch because the code was hardcoding bullseye as the Debian codename for all ASIC types, but Mellanox requires the actual Debian codename from the syncd container.
How did you do it?
Modified the condition to only use hardcoded bullseye for non-Mellanox platforms on internal-202411
For Mellanox on internal-202411, the code now retrieves the actual Debian codename via docker command
This ensures the correct saithrift package URL is constructed for each platform type
How did you verify/test it?
local test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation