Skip to content

[Platform API][pytest] Test inherited methods in Chassis class#1835

Merged
jleveque merged 2 commits intosonic-net:masterfrom
jleveque:complete_chassis
Jul 1, 2020
Merged

[Platform API][pytest] Test inherited methods in Chassis class#1835
jleveque merged 2 commits intosonic-net:masterfrom
jleveque:complete_chassis

Conversation

@jleveque
Copy link
Copy Markdown
Contributor

@jleveque jleveque commented Jun 30, 2020

Add test methods to test the Chassis class methods which are inherited from the DeviceBase class:

test_get_name
test_get_presence
test_get_model
test_get_serial
test_get_status

Example test results summary (showing legitimate test failures):

============================= test session starts =============================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.8.1, pluggy-0.13.1
ansible: 2.8.7
rootdir: /var/src/Networking-acs-sonic-mgmt/tests, inifile: pytest.ini
plugins: forked-1.1.3, xdist-1.28.0, ansible-2.2.2, repeat-0.8.0
collected 19 items

platform_tests/api/test_chassis.py FFFFF..............       [100%]

=================================== FAILURES ==================================
...
=========================== short test summary info ===========================
FAILED platform_tests/api/test_chassis.py::TestChassisAPI::test_get_name - F...
FAILED platform_tests/api/test_chassis.py::TestChassisAPI::test_get_presence...
FAILED platform_tests/api/test_chassis.py::TestChassisAPI::test_get_model - ...
FAILED platform_tests/api/test_chassis.py::TestChassisAPI::test_get_serial -...
FAILED platform_tests/api/test_chassis.py::TestChassisAPI::test_get_status -...
==================== 5 failed, 14 passed in 317.91 seconds ====================

@jleveque jleveque requested review from sujinmkang and yxieca June 30, 2020 20:03
@jleveque jleveque self-assigned this Jun 30, 2020
@jleveque
Copy link
Copy Markdown
Contributor Author

jleveque commented Jun 30, 2020

Retest vsimage please

4 similar comments
@jleveque
Copy link
Copy Markdown
Contributor Author

jleveque commented Jul 1, 2020

Retest vsimage please

@jleveque
Copy link
Copy Markdown
Contributor Author

jleveque commented Jul 1, 2020

Retest vsimage please

@jleveque
Copy link
Copy Markdown
Contributor Author

jleveque commented Jul 1, 2020

Retest vsimage please

@jleveque
Copy link
Copy Markdown
Contributor Author

jleveque commented Jul 1, 2020

Retest vsimage please

@jleveque
Copy link
Copy Markdown
Contributor Author

jleveque commented Jul 1, 2020

Retest vsimage please

@jleveque jleveque merged commit 051a3b5 into sonic-net:master Jul 1, 2020
@jleveque jleveque deleted the complete_chassis branch July 1, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

@sujinmkang sujinmkang Awaiting requested review from sujinmkang

Assignees

@jleveque jleveque

Labels

Enhancement Platform Pytest 🐍

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jleveque @yxieca