Skip to content

[action] [PR:18092] [dualtor] Refine fdb_mac_learning_test.py#18172

Merged
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/18092
Apr 29, 2025
Merged

[action] [PR:18092] [dualtor] Refine fdb_mac_learning_test.py#18172
mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld:cherry/202411/18092

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

few improvements/fixes to fdb_mac_learning_test.py:

  1. replace the config reload in the setup with sonic-clear commands to cleanup fdb/arp entries in setup, this reduces the reload overhead.
  2. send ARP packets instead of simple Ether packets to populate fdb table, this avoids the complex toggle logic on dualtor as the ARP packets are duplicated/accepted by both sides regardless of the mux status.
  3. add the ip assignment before the neighbor check to validate the ip is correctly assigned on DUT.
  4. sleep after ip assignment/before ping to wait for the ip assignment finish.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

As the motivation.

How did you verify/test it?

t0:

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED [ 50%]
fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testARPCompleted PASSED [100%]

dualtor:

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED [ 50%]
fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testARPCompleted PASSED [100%]

dualtor-aa:

fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testFdbMacLearning PASSED [ 50%]
fdb/test_fdb_mac_learning.py::TestFdbMacLearning::testARPCompleted PASSED [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

* [dualtor] Refine `fdb_mac_learning_test.py`

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #18092

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 4a3d1d9 into sonic-net:202411 Apr 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants