Skip to content

Skipping test temporarily for caclmgrd updates#17231

Closed
gupurush wants to merge 1 commit intosonic-net:masterfrom
gupurush:gupurush/caclmgrd
Closed

Skipping test temporarily for caclmgrd updates#17231
gupurush wants to merge 1 commit intosonic-net:masterfrom
gupurush:gupurush/caclmgrd

Conversation

@gupurush
Copy link
Copy Markdown
Contributor

@gupurush gupurush commented Feb 27, 2025

Description of PR

Skipping this test file temporarily for caclmgrd updates - sonic-net/sonic-host-services#197

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gupurush / name: Nanma Purushotam (3f52c54)

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

pytest.mark.topology('any')
]

pytest.skip("Skipping this test file temporarily for caclmgrd updates", allow_module_level=True)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not a good way to skip it for all test environment.
We can remove it from .azure-pipelines/pr_test_scripts.yaml
After image fix gets merged, add it back then

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@gupurush gupurush requested a review from ZhaohuiS March 3, 2025 10:17
Copy link
Copy Markdown
Contributor

@ZhaohuiS ZhaohuiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add it back and update the test case according to the changes in sonic-net/sonic-host-services#197

@ZhaohuiS
Copy link
Copy Markdown
Contributor

ZhaohuiS commented Mar 4, 2025

@gupurush could you please also prepare PR for cacl test case update for the PR sonic-net/sonic-host-services#197

@bpar9
Copy link
Copy Markdown
Collaborator

bpar9 commented Mar 4, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ZhaohuiS
Copy link
Copy Markdown
Contributor

@gupurush please update the test_cacl_application and enable it for PR test.

@ZhaohuiS ZhaohuiS closed this Mar 28, 2025
@ZhaohuiS
Copy link
Copy Markdown
Contributor

reopen it to retrigger PR test

@ZhaohuiS ZhaohuiS reopened this Mar 28, 2025
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@gupurush
Copy link
Copy Markdown
Contributor Author

@gupurush seems that we don't need to skip the cacl case in the PR test, right? PR test didn't fail even after your PR sonic-net/sonic-host-services#197

Yes, we can close it. Thank you

@gupurush gupurush closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants