Skip to content

Add t1-isolate-d128-topo.j2 file as a symbol link to t1-tor.j2#15722

Merged
kevinskwang merged 1 commit intosonic-net:masterfrom
wsycqyz:t1-isolate-d128-topo-8122
Nov 25, 2024
Merged

Add t1-isolate-d128-topo.j2 file as a symbol link to t1-tor.j2#15722
kevinskwang merged 1 commit intosonic-net:masterfrom
wsycqyz:t1-isolate-d128-topo-8122

Conversation

@wsycqyz
Copy link
Copy Markdown
Contributor

@wsycqyz wsycqyz commented Nov 25, 2024

Description of PR

Summary:
As part of t1-isolate-d128-topo, t1-isolate-d128-topo.j2 is missing.
Also fix an issue: t0-isolated-d128u128s2-leaf.j2 should be a symbol link to t0-leaf.j2, NOT a file.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

As part of t1-isolate-d128-topo, t1-isolate-d128-topo.j2 is missing.

How did you do it?

Add t1-isolate-d128-topo.j2 as a symbol link to t1-tor.j2

How did you verify/test it?

I make sure the 2 files are symbol link:
image
image

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Copy Markdown
Collaborator

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Shiyan! signed off

Copy link
Copy Markdown
Contributor

@kevinskwang kevinskwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld
Copy link
Copy Markdown
Collaborator

@wsycqyz PR conflicts with 202405 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants