[action] [PR:15017] skipping test_route_flow_counter.py on Cisco 8122 platforms#15505
Merged
mssonicbld merged 1 commit intosonic-net:202405from Nov 12, 2024
Merged
Conversation
…t#15017) * skip route_flow_counter TCs on 8122 platforms * correcting conditional mark sort for test_route_flow_counter.py
Collaborator
Author
|
Original PR: #15017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for Cisco 8122.
root@light-dut:/usr/share/sonic/device/x86_64-8122_64eh_o-r0/Cisco-8122-O64# sudo sonic-db-cli STATE_DB HGET "FLOW_COUNTER_CAPABILITY_TABLE|route" support
true
But 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json because of scale limits (cannot scale more than 50k with the current LPM profile).
As the feature is not enabled for this platform, need to skip this testcase
How did you do it?
Added a skip condition for test test_route_flow_counter.py for Cisco 8122 platforms in file tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Type of change
-Skip testcase
Back port request
-202311
-202405
How did you verify/test it?
Ran test_route_flow_counter.py for 8122. Made sure it was skipped with 'Test not supported for cisco-8122 platform'