Skip to content

[action] [PR:12909] Enable feature autorestart before test_encap_with_mirror_session#13712

Merged
mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld:cherry/202311/12909
Jul 18, 2024
Merged

[action] [PR:12909] Enable feature autorestart before test_encap_with_mirror_session#13712
mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld:cherry/202311/12909

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes #11744
test_encap_with_mirror_session would invoke fixture setup_mirror_session, and it would invoke fixture setup_uplink. There are steps in fixture setup_uplink, which could restart teamd docker, it would lead swss and syncd docker exits.
If the autorestart is disabled in test_pretest.py, then swss and syncd will fail to restart, and then leads to test failure.

This PR fixed the issue by adding a fixture to enable container autorestart before the test running.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

This PR is to enable feature autorestart before test_encap_with_mirror_session.

How did you do it?

This PR fixed the issue by adding a fixture to enable container autorestart before the test running.

How did you verify/test it?

The change is verified by running test_encap_with_mirror_session after test_disable_container_autorestart.

collected 2 items 

test_pretest.py::test_disable_container_autorestart[str2-7050cx3-acs-10] PASSED [ 50%]
test_pretest.py::test_disable_container_autorestart[str2-7050cx3-acs-11] PASSED [100%]
collected 1 item 

dualtor/test_ipinip.py::test_encap_with_mirror_session ^HPASSED [100%] ^H

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #12909

@mssonicbld mssonicbld merged commit 21e6547 into sonic-net:202311 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants