Skip to content

Skip IPV6 variant of testQosSaiDscpQueueMapping if IPV6 is not configured.#12833

Merged
StormLiangMS merged 1 commit intosonic-net:202311from
vivekverma-arista:skip-testQosSaiDscpQueueMapping
May 14, 2024
Merged

Skip IPV6 variant of testQosSaiDscpQueueMapping if IPV6 is not configured.#12833
StormLiangMS merged 1 commit intosonic-net:202311from
vivekverma-arista:skip-testQosSaiDscpQueueMapping

Conversation

@vivekverma-arista
Copy link
Copy Markdown
Contributor

@vivekverma-arista vivekverma-arista commented May 13, 2024

Description of PR

Summary: Skip
Fixes #118

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

IPV6 variant of the test fails

qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping[single_asic-ipv6]
---------------------------------------------------------------------------------------- live log call ----------------------------------------------------------------------------------------
06:25:52 __init__.pytest_runtest_call             L0040 ERROR  | Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/_pytest/python.py", line 1788, in runtest
    self.ihook.pytest_pyfunc_call(pyfuncitem=self)
  File "/usr/local/lib/python3.8/dist-packages/pluggy/_hooks.py", line 493, in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
  File "/usr/local/lib/python3.8/dist-packages/pluggy/_manager.py", line 115, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/usr/local/lib/python3.8/dist-packages/pluggy/_callers.py", line 113, in _multicall
    raise exception.with_traceback(exception.__traceback__)
  File "/usr/local/lib/python3.8/dist-packages/pluggy/_callers.py", line 77, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/lib/python3.8/dist-packages/_pytest/python.py", line 194, in pytest_pyfunc_call
    result = testfunction(**testargs)
  File "/data/tests/qos/test_qos_sai.py", line 1337, in testQosSaiDscpQueueMapping
    "src_port_ip": dutConfig["testPorts"]["src_port_ipv6"],
KeyError: 'src_port_ipv6'

FAILED

This is because IPV6 is disabled on the DUT for the entire qos/test_qos_sai.py: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/qos/qos_sai_base.py#L1818

How did you do it?

The IPV6 variant of this test needs more work or probably should be a new test module altogether therefore skipping the test for now if IPV6 is not found for the interfaces.

How did you verify/test it?

Ran the test with with 202311 image

qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping[single_asic-ipv6] SKIPPED (Skip IPV6 variant as IPV6 not configured)                                                        [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vivekverma-arista
Skip qos/test_qos_sai.py::TestQosSai::testQosSaiDscpQueueMapping[sing…
c96341b 
…le_asic-ipv6] if IPV6 not configured for interfaces
@vivekverma-arista vivekverma-arista changed the title Skip testQosSaiDscpQueueMapping if IPV6 is not configured. Skip IPV6 variant of testQosSaiDscpQueueMapping if IPV6 is not configured. May 13, 2024
@vivekverma-arista
Copy link
Copy Markdown
Contributor Author

vivekverma-arista commented May 13, 2024

PR for master #12834

@vivekverma-arista vivekverma-arista mentioned this pull request May 13, 2024
Merged
8 tasks
@StormLiangMS StormLiangMS merged commit 5e3834a into sonic-net:202311 May 14, 2024
@vivekverma-arista vivekverma-arista deleted the skip-testQosSaiDscpQueueMapping branch May 16, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vivekverma-arista @bingwang-ms @StormLiangMS