Skip to content

[action] [PR:11951] Add multi-asic support for config_reload running_golden_config#12124

Merged
mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld:cherry/202311/11951
Mar 22, 2024
Merged

[action] [PR:11951] Add multi-asic support for config_reload running_golden_config#12124
mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld:cherry/202311/11951

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Signed-off-by: Anand Mehra anamehra@cisco.com

Description of PR

Added support for multi-asic to generate the correct running_golden_config file list for 'config reload -l' command for multi-asic systems

Summary:
Fixes # #11945

During sonic-mgmgt tests, if sanity precheck fails, the scripts try to recover the setup by executing ‘config reload’ with running_golden_config files saved.

the command executed is 'config reload -f -l /etc/sonic/running_golden_config.json'

This command works fine on single asic systems but does not work on multi-asic cards.

For multi asic cards, the config reload expects one global config file and one namespace config file for each namespace:

e.g: for 2 asic LC:

config reload -f -l /etc/sonic/running_golden_config.json,/etc/sonic/running_golden_config0.json,/etc/sonic/running_golden_config2.json

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

recovery via config_reload using running_golden_config files does not work.

How did you do it?

Added support to generate the file list for multi-asic

How did you verify/test it?

stop one of swss service on multi-asic DUT. Trigger a test with presanity.
Presanity detects docker down and triggers recovery.
Check syslogs for proper config reload options.

Any platform specific information?

Supported testbed topology if it's a new test case?

logs

Mar 8 06:26:02.628496 sfd-lc0 INFO python[40007]: ansible-ansible.legacy.command Invoked with executable=/bin/bash _raw_params=config reload -h _uses_shell=True warn=False stdin_add_newline=True strip_empty_ends=True argv=None chdir=None creates=None removes=None stdin=None
Mar 8 06:26:04.090387 sfd-lc0 INFO python[40065]: ansible-ansible.legacy.command Invoked with executable=/bin/bash _raw_params=config reload -y -f -l /etc/sonic/running_golden_config.json,/etc/sonic/running_golden_config0.json,/etc/sonic/running_golden_config1.json,/etc/sonic/running_golden_config2.json &>/dev/null _uses_shell=True warn=False stdin_add_newline=True strip_empty_ends=True argv=None chdir=None creates=None removes=None stdin=None 
Mar 8 06:26:04.960886 sfd-lc0 NOTICE CCmisApi: 'reload' executing with command: config reload -y -f -l /etc/sonic/running_golden_config.json,/etc/sonic/running_golden_config0.json,/etc/sonic/running_golden_config1.json,/etc/sonic/running_golden_config2.json
root@sfd-lc0:/home/cisco# vi /var/log/syslog
root@sfd-lc0:/home/cisco# grep -i unmonit /var/log/syslog
Mar 8 06:26:04.995417 sfd-lc0 INFO monit[743]: 'container_checker' unmonitor on user request
Mar 8 06:26:05.018424 sfd-lc0 INFO monit[743]: 'container_checker' unmonitor action done

Documentation

…-net#11951)

Added support for multi-asic to generate the correct running_golden_config file list for 'config reload -l' command for multi-asic systems
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #11951

@mssonicbld mssonicbld merged commit 71d1c25 into sonic-net:202311 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants