[action] [PR:11951] Add multi-asic support for config_reload running_golden_config#12124
Merged
mssonicbld merged 1 commit intosonic-net:202311from Mar 22, 2024
Merged
Conversation
…-net#11951) Added support for multi-asic to generate the correct running_golden_config file list for 'config reload -l' command for multi-asic systems
8 tasks
Collaborator
Author
|
Original PR: #11951 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anand Mehra anamehra@cisco.com
Description of PR
Added support for multi-asic to generate the correct running_golden_config file list for 'config reload -l' command for multi-asic systems
Summary:
Fixes # #11945
During sonic-mgmgt tests, if sanity precheck fails, the scripts try to recover the setup by executing ‘config reload’ with running_golden_config files saved.
the command executed is 'config reload -f -l /etc/sonic/running_golden_config.json'
This command works fine on single asic systems but does not work on multi-asic cards.
For multi asic cards, the config reload expects one global config file and one namespace config file for each namespace:
e.g: for 2 asic LC:
config reload -f -l /etc/sonic/running_golden_config.json,/etc/sonic/running_golden_config0.json,/etc/sonic/running_golden_config2.json
Type of change
Back port request
Approach
What is the motivation for this PR?
recovery via config_reload using running_golden_config files does not work.
How did you do it?
Added support to generate the file list for multi-asic
How did you verify/test it?
stop one of swss service on multi-asic DUT. Trigger a test with presanity.
Presanity detects docker down and triggers recovery.
Check syslogs for proper config reload options.
Any platform specific information?
Supported testbed topology if it's a new test case?
logs
Documentation