Skip to content

[action] [PR:10941] Add IPv6 TC to queue mapping test#12088

Merged
mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld:cherry/202311/10941
Mar 22, 2024
Merged

[action] [PR:10941] Add IPv6 TC to queue mapping test#12088
mssonicbld merged 1 commit intosonic-net:202311from
mssonicbld:cherry/202311/10941

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Summary:
This change introduces an IPv6 test for TC to queue mapping in the QoS suite alongside the infrastructure needed to construct this test. Resolves #10939

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

There is a missing test gap for IPv6 DSCP to TC queue mapping. This change introduces a test to fill this test gap by modifying an existing test DscpToQueueMapping which previously tested DSCP to TC queue mapping on IPv4 to also test it for IPv6.

How did you do it?

Modified existing testQosSaiDscpQueueMapping to also test for IPv6, and added changes to active_ip_interfaces to also fetch IPv6 addresses to be used in this test.

How did you verify/test it?

Ran the test manually and it passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

This change introduces an IPv6 test for TC to queue mapping in the QoS suite alongside the infrastructure needed to construct this test. Resolves sonic-net#10939
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #10941

@mssonicbld mssonicbld merged commit ca286cf into sonic-net:202311 Mar 22, 2024
"dst_port_2_vlan": dstVlan2,
'dst_port_3_id': dstPort3,
"dst_port_3_ip": dst_test_port_ips[dstPort3]['peer_addr'],
"dst_port_3_ipv6": dst_test_port_ips[dstPort3]['peer_addr_ipv6'],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are seeing this error. What is the expectation of this particular key? The qos-sai-base completely disables the ipv6. So there will be no ipv6 in the DUT at all.

` "src_port_id": srcPort,
"src_port_ip": src_port_ip["peer_addr"],
"src_port_ipv6": src_port_ip["peer_addr_ipv6"],
"src_port_vlan": srcVlan
}
E KeyError: 'peer_addr_ipv6'

dstPort = 0
dstPort2 = 2
dstPort3 = 3
dstPorts = [0, 2, 3]
dstVlan = None
dstVlan2 = None
dstVlan3 = None
dst_dut_port_ids = {0: [0, 1, 2, 3, 4, 5, ...]}
dst_dut_port_ips = {0: {0: {'peer_addr': '192.168.0.2'}, 1: {'peer_addr': '192.168.0.3'}, 2: {'peer_addr': '192.168.0.4'}, 3: {'peer_addr': '192.168.0.5'}, ...}}
dst_port_ids = None
dst_test_port_ids = [0, 1, 2, 3, 4, 5, ...]
dst_test_port_ips = {0: {'peer_addr': '192.168.0.2'}, 1: {'peer_addr': '192.168.0.3'}, 2: {'peer_addr': '192.168.0.4'}, 3: {'peer_addr': '192.168.0.5'}, ...}
get_src_dst_asic_and_duts = {'all_asics': [<SonicAsic 0>], 'all_duts': [], 'dst_asic': <SonicAsic 0>, 'dst_asic_index': 0, ...}
request = <SubRequest 'dutConfig' for <Function testQosSaiDscpQueueMapping[single_asic-ipv4]>>
self = <tests.qos.test_qos_sai.TestQosSai object at 0x7f3fc262ca90>
srcPort = 1
srcPorts = [1]
srcVlan = None
src_dut_port_ids = {0: [0, 1, 2, 3, 4, 5, ...]}
src_dut_port_ips = {0: {0: {'peer_addr': '192.168.0.2'}, 1: {'peer_addr': '192.168.0.3'}, 2: {'peer_addr': '192.168.0.4'}, 3: {'peer_addr': '192.168.0.5'}, ...}}
src_port_ids = None
src_port_ip = {'peer_addr': '192.168.0.3'}
src_test_port_ids = [0, 1, 2, 3, 4, 5, ...]
src_test_port_ips = {0: {'peer_addr': '192.168.0.2'}, 1: {'peer_addr': '192.168.0.3'}, 2: {'peer_addr': '192.168.0.4'}, 3: {'peer_addr': '192.168.0.5'}, ...}
testPortIds = {0: {0: [0, 1, 2, 3, 4, 5, ...]}}
testPortIps = {0: {0: {0: {'peer_addr': '192.168.0.2'}, 1: {'peer_addr': '192.168.0.3'}, 2: {'peer_addr': '192.168.0.4'}, 3: {'peer_addr': '192.168.0.5'}, ...}}}
uplinkPortIds = []

qos/qos_sai_base.py:769: KeyError
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants