New IXIA PFC-WD test for low traffic and low XOFF rate#11091
Open
rraghav-cisco wants to merge 8 commits intosonic-net:masterfrom
Open
New IXIA PFC-WD test for low traffic and low XOFF rate#11091rraghav-cisco wants to merge 8 commits intosonic-net:masterfrom
rraghav-cisco wants to merge 8 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
@alpeshspatel , @rbpittman for viz. |
| burst_cycle_sec = poll_interval_sec + detect_time_sec + restore_time_sec + 0.1 | ||
| data_flow_dur_sec = ceil(burst_cycle_sec * BURST_EVENTS) | ||
| pause_flow_dur_sec = poll_interval_sec * 0.5 | ||
| burst_cycle_sec = 2 * (poll_interval_sec + detect_time_sec + restore_time_sec + 0.1) |
Contributor
Author
There was a problem hiding this comment.
will change to cisco-8000 only.
Contributor
Author
There was a problem hiding this comment.
Original test must be run without changing any test behaviour. Add a multiplier only for the low-traffic scenario.
Contributor
Author
|
Results: Older image:Newer images: |
Contributor
|
let's have multi-dut version also for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifying the existing pfcwd snappi test to reproduce a corner case in pfcwd.
Type of change
[] Bug fix
[X] Test case(new/improvement)
[] Testbed and Framework(new/improvement)
Back port request
[] 201911
[] 202012
[x] 202205
[x] 202305
Approach
What is the motivation for this PR?
This PR is to add a new test to cover the corner case in pfcwd (low number of pfc pause frames, and a very low traffic). This condition triggered pfcwd in cisco-8000 though it shouldn't have.
How did you do it?
I have added new parameters to the existing testcase. One set of parameters is same as the original test itself. The second set of parameters tests out the corner case as explained above.
How did you verify/test it?
Ran both tests with cisco-8000 platform, once without image fix, and once with the image fix.
Any platform specific information?
No.
Without the fix:
=========================================================================================================== PASSES ===========================================================================================================
________________________________________________________________________________ test_pfcwd_burst_storm_single_lossless_prio[95-None-None-1] _________________________________________________________________________________
------------------------------------------------------------------- generated xml file: /run_logs/ixia/8030/2023-12-23-01-26-43/tr_2023-12-23-01-26-43.xml -------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
--------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
02:06:06 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
================================================================================================== short test summary info ===================================================================================================
PASSED snappi_tests/pfcwd/test_pfcwd_burst_storm_with_snappi.py::test_pfcwd_burst_storm_single_lossless_prio[95-None-None-1]
FAILED snappi_tests/pfcwd/test_pfcwd_burst_storm_with_snappi.py::test_pfcwd_burst_storm_single_lossless_prio[2e-05-1000-5-10] - RuntimeError: Packet drops or other issues are seen in 10 attempts out of 10.
=========================================================================================== 1 failed, 1 passed in 2361.12 seconds ============================================================================================
AzDevOps@e200d6aa4ff5:/data/tests$
With the fix:
________________________________________________________________________________ test_pfcwd_burst_storm_single_lossless_prio[95-None-None-1] _________________________________________________________________________________
________________________________________________________________________________ test_pfcwd_burst_storm_single_lossless_prio[2e-05-1000-5-10] ________________________________________________________________________________
------------------------------------------------------------------- generated xml file: /run_logs/ixia/8030/2023-12-23-00-35-18/tr_2023-12-23-00-35-18.xml -------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
--------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
01:14:35 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
================================================================================================== short test summary info ===================================================================================================
PASSED snappi_tests/pfcwd/test_pfcwd_burst_storm_with_snappi.py::test_pfcwd_burst_storm_single_lossless_prio[95-None-None-1]
PASSED snappi_tests/pfcwd/test_pfcwd_burst_storm_with_snappi.py::test_pfcwd_burst_storm_single_lossless_prio[2e-05-1000-5-10]
================================================================================================ 2 passed in 2355.75 seconds =================================================================================================
AzDevOps@e200d6aa4ff5:/data/tests$