[202205] Improve the stability of fib/decap test#10416
Merged
wangxin merged 1 commit intosonic-net:202205from Oct 30, 2023
Merged
[202205] Improve the stability of fib/decap test#10416wangxin merged 1 commit intosonic-net:202205from
wangxin merged 1 commit intosonic-net:202205from
Conversation
1. Add a timeout in the packet verification for sometimes there could be a big delay(max 0.3s on our testbed) between the packet is received by the hypervisor and the ptf adapter. 2. Decrease the BALANCING_TEST_TIMES in the fib_hash test, if too many packets are sent in the test, there could be packet loss in the hypervisor server. 250 times is enough for the test.
7 tasks
nhe-NV
approved these changes
Oct 28, 2023
wangxin
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This is the manual cherry-pick of PR #10415 for conflict resolving.
The fib/decap tests occasionally fail on or testbeds due to some random packet is not received by the ptf. After the debugging we found that there may be a big delay(max 0.3s observed on our testbed) between the packet is send by the ptf src port and received by the ptf dst port.
We suspect it could be introduced by the lag on the server side, because we see this failure mostly on the t1-lag/t1-lag-64 topologies.
And in the fib hash test, it looks like sometimes the packet is totally lost on the server(we have checked that there was no packet loss on the dut and fanout).
We have found a way to prevent this failure by:
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix that occasional packet loss failure in fib/decap tests.
How did you do it?
Check the summary.
How did you verify/test it?
We have run the regression with this fix for one week, the failure is no longer seen.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation