DTS file as a patch for Nexthop bmc card#537
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nate-nexthop
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Chandrasekaran Swaminathan <chander@nexthop.ai>
## Patch List * 0056-hwmon-pmbus-mp2845-Add-support-for-MP2845-device.patch : * 0057-hwmon-pmbus-mp5926-Add-support-for-MP5926-device.patch : Signed-off-by: sw-r2d2-bot <sw-r2d2-bot@nvidia.com> Signed-off-by: Chandrasekaran Swaminathan <chander@nexthop.ai>
Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com> Signed-off-by: Chandrasekaran Swaminathan <chander@nexthop.ai>
Signed-off-by: Chandrasekaran Swaminathan <chander@nexthop.ai>
47aeee0 to
d1e0595
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Could you please rebase on the master branch, so that unrelated commits are not included? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Done. Apologies for the faux pass |
| + model = "NextHop B27 R0"; | ||
| + compatible = "nexthop,nexthop-b27-r0", "aspeed,ast2700-evb", "aspeed,ast2700"; | ||
| + |
There was a problem hiding this comment.
If we go by this model, most of the elements of the DTS will be common across all vendors as there seems to be a consensus that we will be using a bare minimum feature set of BMC in SONiC and most of the platform will be controlled by the host CPU.
Given that DTS of every vendor will have a lot of common code. Will it be a good idea to have this in two steps as follows -
- Community agrees on a common DTSI for AST2700 which will be submitted to sonic-linux-kernel.
- When a vendor submits their own DTS they include the common DTSI and add/override elements specific to their platform like
compatiblestring and other elements.
There was a problem hiding this comment.
There can be a common DTSi that everyone includes, but I think we can do that refactoring later after we have couple of vendors with their DTS files.
Signed-off-by: Chandrasekaran Swaminathan <chander@nexthop.ai>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Chandrasekaran Swaminathan <chander@nexthop.ai>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Added a DTS file for the nexthop bmc card.