NPU disabled used PCIe BAR#248
Merged
saiarcot895 merged 2 commits intosonic-net:masterfrom Dec 6, 2021
Merged
Conversation
For Cisco ASIC only BAR0 is valid. Not disabling other BAR's was resulting in pci_enable_device function failure in P0 Pacific ASIC's. Further debugging and consultion with Hardware team, issue seems to be related to only P0 version of ASIC and workaround suggested is to disable unused PCI BAR. This is same pull request reviewed ealier, sonic-net#225 Cisco experimented removing this patch, but identified that there are boards in the field with Pacific ASIC. This patch is need for these ASIC's to work, hence re-submitting. Signed-off-by: Madhava Reddy Siddareddygari <msiddare@cisco.com>
|
@saiarcot895 fyi |
paulmenzel
suggested changes
Dec 1, 2021
Contributor
paulmenzel
left a comment
There was a problem hiding this comment.
So this patch was dropped when moving from Linux 4.19 to 5.10? If so, please add that to the merge/pull request and commit message description.
Also, please add somewhere, what NPU means.
Some minor nit:
This patch is need for these ASIC's to work, hence re-submitting.
is needed
saiarcot895
requested changes
Dec 1, 2021
Signed-off-by: Madhava Reddy Siddareddygari <msiddare@cisco.com>
saiarcot895
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Cisco ASIC only BAR0 is valid. Not disabling other BAR's
was resulting in pci_enable_device function failure in P0
Pacific ASIC's. Further debugging and consultion with Hardware
team, issue seems to be related to only P0 version of ASIC and
workaround suggested is to disable unused PCI BAR.
This is same pull request reviewed ealier,
#225
Cisco experimented removing this patch, but identified that
there are boards in the field with Pacific ASIC.
This patch is needed for these ASIC's to work, hence re-submitting.
NPU is commonly used name for the packet forwarding ASIC's.
Signed-off-by: Madhava Reddy Siddareddygari msiddare@cisco.com