fix kernel compile problem for arm64 by taocy001 · Pull Request #137 · sonic-net/sonic-linux-kernel

taocy001 · 2020-05-25T06:16:28Z

generate .config files for armhf, arm64, amd64 in turn.
Compile the kernel with the corresponding environment variable.
rely on updates to the sonic-slave-buster, see PR Arm64 buster build sonic-buildimage#4639.

lguohan · 2020-05-25T06:25:03Z

can you check the build failure?

taocy001 · 2020-05-25T07:19:40Z

can you check the build failure?

These changes rely on updates to the sonic-slave-buster.
in sonic-net/sonic-buildimage#4639
add:

# For march kernel compile
RUN apt-get install -y crossbuild-essential-amd64 \
        crossbuild-essential-arm64 \
        crossbuild-essential-armhf

taocy001 · 2020-05-26T12:21:30Z

retest this please

lguohan · 2020-05-26T16:12:14Z

the build image pr has been merged. can you check the build failure?

lguohan · 2020-05-27T07:18:25Z

@antony-rheneus, can you take a look at this pr?

antony-rheneus · 2020-05-27T11:49:08Z

Makefile

 ORIG_FILE_URL = "http://security.debian.org/debian-security/pool/updates/main/l/linux/linux_4.19.67.orig.tar.xz"

+define dpkg-architecture-armhf
+        $(shell dpkg-architecture -aarmhf) CROSS_COMPILE=arm-linux-gnueabihf-


No need of cross compilation, as multi arch is enabled

antony-rheneus · 2020-05-27T11:53:47Z

Makefile

-	# fakeroot make -f debian/rules.gen setup_armhf_none_armmp
-	# fakeroot make -f debian/rules.gen setup_arm64_none
-	fakeroot make -f debian/rules.gen setup_amd64_none_amd64
+	$(call dpkg-architecture-armhf) fakeroot make -f debian/rules.gen setup_armhf_none_armmp


The one mentioned in this comment also does the job
#121 (comment)

antony-rheneus · 2020-05-27T11:55:31Z

Makefile

-	DO_DOCS=False fakeroot make -f debian/rules -j $(shell nproc) binary-indep
 ifeq ($(CONFIGURED_ARCH), armhf)
-	fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none_armmp
+	$(call dpkg-architecture-armhf) DO_DOCS=False fakeroot make -f debian/rules -j $(shell nproc) binary-indep


Can reduce multiple/else by.

DO_DOCS=False ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules -j $(shell nproc) binary-indep

antony-rheneus · 2020-05-27T11:57:15Z

Makefile

+else
+ifeq ($(CONFIGURED_ARCH), arm64)
+	$(call dpkg-architecture-arm64) DO_DOCS=False fakeroot make -f debian/rules -j $(shell nproc) binary-indep
+	$(call dpkg-architecture-arm64) fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none


Can reduce arch check if else by,
ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none

antony-rheneus · 2020-05-27T13:18:15Z

can you check the build failure?

These changes rely on updates to the sonic-slave-buster.
in Azure/sonic-buildimage#4639
add:
# For march kernel compile
RUN apt-get install -y crossbuild-essential-amd64 \
        crossbuild-essential-arm64 \
        crossbuild-essential-armhf

multi-arch docker usage is to get rid of cross compilation. without cross building multi-arch uses native(ARM) (not the host) gcc tools

antony-rheneus · 2020-05-27T13:43:43Z

I would rather propose below change.

@@ -74,13 +74,13 @@ $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% :
        debian/bin/gencontrol.py

        # generate linux build file for amd64_none_amd64
-       # fakeroot make -f debian/rules.gen setup_armhf_none_armmp
-       # fakeroot make -f debian/rules.gen setup_arm64_none
-       fakeroot make -f debian/rules.gen setup_amd64_none_amd64
+       fakeroot make -f debian/rules.gen DEB_HOST_ARCH=armhf setup_armhf_none_armmp
+       fakeroot make -f debian/rules.gen DEB_HOST_ARCH=arm64 setup_arm64_none
+       fakeroot make -f debian/rules.gen DEB_HOST_ARCH=amd64 setup_amd64_none_amd64

        # Applying patches and configuration changes
-       # git add debian/build/build_armhf_none_armmp/.config -f
-       # git add debian/build/build_arm64_none_arm64/.config -f
+       git add debian/build/build_armhf_none_armmp/.config -f
+       git add debian/build/build_arm64_none_arm64/.config -f
        git add debian/build/build_amd64_none_amd64/.config -f
        git add debian/config.defines.dump -f
        git add debian/control -f
@@ -93,9 +93,9 @@ $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% :
        stg import -s ../patch/series

        # Building a custom kernel from Debian kernel source
-       DO_DOCS=False fakeroot make -f debian/rules -j $(shell nproc) binary-indep
+       DO_DOCS=False ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules -j $(shell nproc) binary-indep
 ifeq ($(CONFIGURED_ARCH), armhf)
-       fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none_armmp
+       ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none_armmp
 else
-       fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none
+		ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none

 endif

lguohan · 2020-05-27T16:40:59Z

@taocy001 , can you look at the suggestion from @antony-rheneus

taocy001 · 2020-05-27T20:27:09Z

I would rather propose below change.


@@ -74,13 +74,13 @@ $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% :

        debian/bin/gencontrol.py



        # generate linux build file for amd64_none_amd64

-       # fakeroot make -f debian/rules.gen setup_armhf_none_armmp

-       # fakeroot make -f debian/rules.gen setup_arm64_none

-       fakeroot make -f debian/rules.gen setup_amd64_none_amd64

+       fakeroot make -f debian/rules.gen DEB_HOST_ARCH=armhf setup_armhf_none_armmp

+       fakeroot make -f debian/rules.gen DEB_HOST_ARCH=arm64 setup_arm64_none

+       fakeroot make -f debian/rules.gen DEB_HOST_ARCH=amd64 setup_amd64_none_amd64



        # Applying patches and configuration changes

-       # git add debian/build/build_armhf_none_armmp/.config -f

-       # git add debian/build/build_arm64_none_arm64/.config -f

+       git add debian/build/build_armhf_none_armmp/.config -f

+       git add debian/build/build_arm64_none_arm64/.config -f

        git add debian/build/build_amd64_none_amd64/.config -f

        git add debian/config.defines.dump -f

        git add debian/control -f

@@ -93,9 +93,9 @@ $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% :

        stg import -s ../patch/series



        # Building a custom kernel from Debian kernel source

-       DO_DOCS=False fakeroot make -f debian/rules -j $(shell nproc) binary-indep

+       DO_DOCS=False ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules -j $(shell nproc) binary-indep

 ifeq ($(CONFIGURED_ARCH), armhf)

-       fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none_armmp

+       ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none_armmp

 else

-       fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none

+		ARCH=$(CONFIGURED_ARCH) DEB_HOST_ARCH=$(CONFIGURED_ARCH) fakeroot make -f debian/rules.gen -j $(shell nproc) binary-arch_$(CONFIGURED_ARCH)_none



 endif

This should be a better way to modify it.

lguohan · 2020-05-27T20:28:10Z

thanks, can you update the pr then?

taocy001 · 2020-05-27T20:35:12Z

thanks, can you update the pr then?

Ok, I'll update the PR after reworking and testing.

taocy001 · 2020-05-30T10:11:19Z

@lguohan @antony-rheneus
updated, please review.

fix kernel compile problem for arm64

2548e1d

taocy001 mentioned this pull request May 25, 2020

add CENTEC tsingma SoC platform support #139

Closed

taocy001 mentioned this pull request May 26, 2020

Add centec arm64 architecture support for E530 sonic-net/sonic-buildimage#4641

Merged

sonic-net deleted a comment from taocy001 May 27, 2020

lguohan approved these changes May 27, 2020

View reviewed changes

antony-rheneus reviewed May 27, 2020

View reviewed changes

Simplify the statement of environmental variables

c5e5463

lguohan merged commit f07f74f into sonic-net:master May 30, 2020

antony-rheneus mentioned this pull request Jun 1, 2020

ARM arch support for SONIC sonic-net/sonic-buildimage#3271

Closed

taocy001 deleted the arm64_buster_build branch June 3, 2020 01:47

Conversation

taocy001 commented May 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lguohan commented May 25, 2020

Uh oh!

taocy001 commented May 25, 2020

Uh oh!

taocy001 commented May 26, 2020

Uh oh!

lguohan commented May 26, 2020

Uh oh!

lguohan commented May 27, 2020

Uh oh!

antony-rheneus May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antony-rheneus May 27, 2020

Choose a reason for hiding this comment

Uh oh!

antony-rheneus May 27, 2020

Choose a reason for hiding this comment

Uh oh!

antony-rheneus May 27, 2020

Choose a reason for hiding this comment

Uh oh!

antony-rheneus commented May 27, 2020

Uh oh!

antony-rheneus commented May 27, 2020

Uh oh!

lguohan commented May 27, 2020

Uh oh!

taocy001 commented May 27, 2020

Uh oh!

lguohan commented May 27, 2020

Uh oh!

taocy001 commented May 27, 2020

Uh oh!

taocy001 commented May 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

taocy001 commented May 25, 2020 •

edited

Loading

antony-rheneus May 27, 2020 •

edited

Loading