[202211][config reload] Config Reload Enhancement#64
Merged
StormLiangMS merged 2 commits intosonic-net:202211from Jun 10, 2023
Merged
[202211][config reload] Config Reload Enhancement#64StormLiangMS merged 2 commits intosonic-net:202211from
StormLiangMS merged 2 commits intosonic-net:202211from
Conversation
Code changes for config reload Enhancement sonic-net/SONiC#1203. Enhancing config reload to sequence the services and faster system initialization. Immediately restart the critical services during config reload. The non critical should be started only after all the ports are initialized. Services can be configured to be started immediately or delayed. This can be using a field in FEATURE table. The existing timers should be removed by this event driven approach. This flow is applicable in case of all reboots (warm/fast/cold) as well as config reload.
qiluo-msft
approved these changes
Jun 9, 2023
wenyiz2021
reviewed
Aug 16, 2023
| feature_cfg (dict): Feature CONFIG_DB configuration | ||
| deviec_config (dict): DEVICE_METADATA section of CONFIG_DB | ||
| """ | ||
| if 'has_timer' in feature_cfg: |
There was a problem hiding this comment.
hi @dgsudharsan , wonder why you don't want 'has_timer' in config_db.json, FEATURE section?
Contributor
Author
There was a problem hiding this comment.
@wenyiz2021 Please refer to this comment #45 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #45
Code changes for config reload Enhancement sonic-net/SONiC#1203.
Enhancing config reload to sequence the services and faster system initialization.
Immediately restart the critical services during config reload.
The non critical should be started only after all the ports are initialized.
Services can be configured to be started immediately or delayed. This can be using a field in FEATURE table.
The existing timers should be removed by this event driven approach.
This flow is applicable in case of all reboots (warm/fast/cold) as well as config reload.