Implemented ssh configurations by ycoheNvidia · Pull Request #32 · sonic-net/sonic-host-services

ycoheNvidia · 2023-01-10T08:01:42Z

Why I did it

Implemented ssh configurations

How I did it

Added ssh config table in configDB, once changed - hostcfgd will change the relevant OS files (sshd_config)

How to verify it

Tests in added in this PR. User can change relevant configs in configDB such as ports, and see sshd port was modified

Description for the changelog

Added ssh config infrastructure

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Which release branch to backport (provide reason below if selected)

202205
202211
202305

Link to config_db schema for YANG module changes

https://github.com/ycoheNvidia/SONiC/blob/ssh_config/doc/ssh_config/ssh_config.md

A picture of a cute animal (not mandatory but encouraged)

HLD in sonic-net/SONiC#1075
This PR is related to sonic-net/sonic-buildimage#13338

liat-grozovik · 2023-02-02T12:29:59Z

@ycoheNvidia please handle conflicts
@qiluo-msft could you please help to review or assign someone?

ycoheNvidia · 2023-02-02T12:53:43Z

@ycoheNvidia please handle conflicts @qiluo-msft could you please help to review or assign someone?

resolved

liat-grozovik · 2023-02-14T07:06:43Z

@ycoheNvidia could you please rerun checkers and follow up on failures?

ycoheNvidia · 2023-02-14T13:40:33Z

@ycoheNvidia could you please rerun checkers and follow up on failures?

fixed

scripts/hostcfgd

liat-grozovik · 2023-04-15T08:55:34Z

@dgsudharsan @qiluo-msft any further comments on this PR or can it be merged?

dgsudharsan · 2023-04-15T17:55:28Z

@dgsudharsan @qiluo-msft any further comments on this PR or can it be merged?

@liat-grozovik , There is still one comment pending. I don't want run_cmd to be replaced with os.system since its a security vulnerability.

…ssh_config

Replaced all ssh related os.cmd calls with modify_single_file_inplace and fixed it on the way

ycoheNvidia · 2023-05-22T07:17:47Z

@dgsudharsan @qiluo-msft any further comments on this PR or can it be merged?

@liat-grozovik , There is still one comment pending. I don't want run_cmd to be replaced with os.system since its a security vulnerability.

Comment was addressed. Thanks!

ycoheNvidia · 2023-06-04T13:46:41Z

@qiluo-msft please add your comments/approval

qiluo-msft · 2023-06-19T06:59:34Z

Could you add HLD PR to this PR's description?
Could you add this PR's link into HLD PR's PR description? There should be a table containing all the PR for that HLD.

In reply to: 1596617344

scripts/hostcfgd

liuh-80 · 2023-06-19T07:04:59Z

@ycoheNvidia , in the PR description this PR depends on another PR merge first: sonic-net/sonic-buildimage#13319
But it's closed, what's the plan for that PR?

#closed

ycoheNvidia · 2023-06-19T07:07:33Z

@ycoheNvidia , in the PR description this PR depends on another PR merge first: sonic-net/sonic-buildimage#13319 But it's closed, what's the plan for that PR?

Updated the description - link was updated to sonic-net/sonic-buildimage#13338

scripts/hostcfgd

ycoheNvidia · 2023-06-19T12:07:17Z

Could you add HLD PR to this PR's description? Could you add this PR's link into HLD PR's PR description? There should be a table containing all the PR for that HLD.

done

qiluo-msft · 2023-06-20T05:29:56Z

Could you merge the latest master code? Semgrep check is recently added into master, and this PR did not trigger it.

…ssh_config

ycoheNvidia · 2023-06-20T05:57:53Z

Could you merge the latest master code? Semgrep check is recently added into master, and this PR did not trigger it.

Done

ycoheNvidia · 2023-06-25T18:28:28Z

@liuh-80 @qiluo-msft all comments addressed, please take another look

qiluo-msft

LGTM. Please check with other active reviewers.

Implemented ssh configurations

eab3d0a

ycoheNvidia mentioned this pull request Jan 10, 2023

SSH global config sonic-net/SONiC#1075

Merged

ycoheNvidia marked this pull request as draft January 10, 2023 09:38

ycoheNvidia marked this pull request as ready for review January 10, 2023 09:42

Configure LoginGraceTime instead of ClientAliveInterval

7be167c

Merge branch 'master' into sonic-host-services-ycoheNvidia-ssh_config

26583d0

fixed test issues

9be6722

dgsudharsan requested changes Mar 10, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

scripts/hostcfgd Outdated Show resolved Hide resolved

dgsudharsan requested changes Mar 10, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

Minor fixes

b46d7c7

ycoheNvidia closed this Mar 13, 2023

ycoheNvidia deleted the sonic-host-services-ycoheNvidia-ssh_config branch March 13, 2023 07:16

ycoheNvidia restored the sonic-host-services-ycoheNvidia-ssh_config branch March 19, 2023 07:03

ycoheNvidia reopened this Mar 19, 2023

ycoheNvidia added 2 commits March 20, 2023 13:04

fixed test issue

b6434d5

Fixed sec command call and tests

1146857

dgsudharsan requested changes Mar 29, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

ycoheNvidia and others added 2 commits May 17, 2023 11:46

Merge branch 'sonic-net:master' into sonic-host-services-ycoheNvidia-…

4d4337f

…ssh_config

Replaced os.cmd to subprocess.run

200bf27

Replaced all ssh related os.cmd calls with modify_single_file_inplace and fixed it on the way

ycoheNvidia force-pushed the sonic-host-services-ycoheNvidia-ssh_config branch from 73a2fff to 200bf27 Compare May 18, 2023 13:19

ycoheNvidia mentioned this pull request May 22, 2023

Added ssh configurations to YANG model sonic-net/sonic-buildimage#13338

Merged

3 tasks

dgsudharsan approved these changes May 22, 2023

View reviewed changes

Merge branch 'master' into sonic-host-services-ycoheNvidia-ssh_config

f4aaec8

qiluo-msft requested a review from liuh-80 June 19, 2023 06:58

qiluo-msft reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Show resolved Hide resolved

qiluo-msft requested a review from maipbui June 19, 2023 07:07

qiluo-msft reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

qiluo-msft requested a review from Blueve June 19, 2023 07:08

qiluo-msft reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

Update hostcfgd

fd9f7e3

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Show resolved Hide resolved

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Show resolved Hide resolved

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Show resolved Hide resolved

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

liuh-80 reviewed Jun 19, 2023

View reviewed changes

scripts/hostcfgd Outdated Show resolved Hide resolved

sonic-net deleted a comment from azure-pipelines bot Jun 20, 2023

Merge branch 'sonic-net:master' into sonic-host-services-ycoheNvidia-…

561209d

…ssh_config

Multiple fixes after review

9872957

qiluo-msft approved these changes Jun 25, 2023

View reviewed changes

Imporved sshd verification and processing

c24d06e

liuh-80 approved these changes Jun 26, 2023

View reviewed changes

liat-grozovik merged commit bc08806 into sonic-net:master Jun 27, 2023

Conversation

ycoheNvidia commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Which release branch to backport (provide reason below if selected)

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

liat-grozovik commented Feb 2, 2023

Uh oh!

ycoheNvidia commented Feb 2, 2023

Uh oh!

liat-grozovik commented Feb 14, 2023

Uh oh!

ycoheNvidia commented Feb 14, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liat-grozovik commented Apr 15, 2023

Uh oh!

dgsudharsan commented Apr 15, 2023

Uh oh!

ycoheNvidia commented May 22, 2023

Uh oh!

ycoheNvidia commented Jun 4, 2023

Uh oh!

qiluo-msft commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

liuh-80 commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ycoheNvidia commented Jun 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ycoheNvidia commented Jun 19, 2023

Uh oh!

qiluo-msft commented Jun 20, 2023

Uh oh!

ycoheNvidia commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ycoheNvidia commented Jun 25, 2023

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ycoheNvidia commented Jan 10, 2023 •

edited

Loading

qiluo-msft commented Jun 19, 2023 •

edited

Loading

liuh-80 commented Jun 19, 2023 •

edited

Loading

ycoheNvidia commented Jun 20, 2023 •

edited

Loading