Merged
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Thanks for your valuable feedback, @ram25794. Based on your suggestion, we've updated the SSH_KEY and SSH_PATH to lowercase in the PR for consistency with other config variables. All necessary changes have been made, and we've tested the updates thoroughly. Please review the updated PR, and I would appreciate your approval for merging it |
wajahatrazi
reviewed
Feb 10, 2025
| "remote": "false", # New feature: remote, default is "false" | ||
| "SSH_KEY": "<user@server>", # New feature: SSH key, default value | ||
| "SSH_PATH": "<path>" # New feature: SSH path, default value | ||
| "ssh_key": "<user@server>", # New feature: SSH key, default value |
There was a problem hiding this comment.
The PR that you have created, does not reflect the YANG model leaf names, as it was suggested.
Kindly refer to the YANG model mentioned below
wajahatrazi
reviewed
Feb 10, 2025
| call(['sonic-kdump-config', '--num_dumps', '3']), | ||
| call(['sonic-kdump-config', '--memory', '0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M']), | ||
| call(['sonic-kdump-config', '--remote', 'false']), # Covering remote | ||
| call(['sonic-kdump-config', '--ssh_key', '<user@server>']), # Covering ssh_key |
Contributor
There was a problem hiding this comment.
Could you clarify which word has typo?
Contributor
There was a problem hiding this comment.
should be --ssh_string?
qiluo-msft
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SSH_KEY to ssh_key and SSH_PATH to ssh_path and ssh_path respectively to maintain consistency with lowercase naming conventions in the configuration and YANG model. This change ensures uniform key formatting across the system.