Skip to content

Allow ability to invoke platform specific hooks in swss#7621

Closed
VenkatCisco wants to merge 2 commits intosonic-net:masterfrom
VenkatCisco:VenkatCisco/PR9_swss_hooks
Closed

Allow ability to invoke platform specific hooks in swss#7621
VenkatCisco wants to merge 2 commits intosonic-net:masterfrom
VenkatCisco:VenkatCisco/PR9_swss_hooks

Conversation

@VenkatCisco
Copy link
Copy Markdown
Contributor

@VenkatCisco VenkatCisco commented May 17, 2021

Why I did it

Implement a platform agnostic approach to source a script as desired.
If it exits it checks if there is a file to source and hence does the needful.

How I did it

This is a PR followup from the code-review discussion we had with Guhon/Judy and team. This also addresses the following two comments:

  • Convert to sourcing a file instead of executing the same., so the logic within is run in the same shell.
  • Use sonic_asic_platform instead of PLATFORM_DIR

How to verify it

Perform run time check for files sourced via the swss.sh hooks and execute the same.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@VenkatCisco VenkatCisco requested a review from lguohan as a code owner May 17, 2021 02:20
@VenkatCisco VenkatCisco changed the title Venkat cisco/pr9 swss hooks Allow ability to invoke platform specific hooks in syncd.sh May 18, 2021
@VenkatCisco VenkatCisco changed the title Allow ability to invoke platform specific hooks in syncd.sh Allow ability to invoke platform specific hooks in swss May 18, 2021
@VenkatCisco
Copy link
Copy Markdown
Contributor Author

As per the chassis group discussion and previous PR reviews, it was concluded that this PR is essential for the multi-asic instance bring up. Additionally, cisco will look into how multi-instance services (syncd and teamd) will need to orchestrated when corresponding asic is present. To that follow up, git issue #7699 is raised to track and develop the required enhancement.

So please help approve this PR.

@anshuv-mfst
Copy link
Copy Markdown

Chassis subgroup meeting 5/26:
Need enhancements to this PR, please look into https://github.com/Azure/sonic-platform-common/pull/185/files and https://github.com/Azure/sonic-platform-daemons/pull/175/files and follow same method.

@anshuv-mfst
Copy link
Copy Markdown

To be tracked via #7477 , please close this PR.

@VenkatCisco
Copy link
Copy Markdown
Contributor Author

This feature support will be tracked thru #7477. Hence closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants