kdump: Add default kdump command line arguments#6180
Merged
lguohan merged 1 commit intosonic-net:masterfrom Dec 15, 2020
Merged
kdump: Add default kdump command line arguments#6180lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
The default /etc/default/kdump-tools file provided by the kdump-tools package doesn't set a value for KDUMP_CMDLINE_APPEND. The default kdump command line arguments need to be set in order to extend them to use additional arguments required for SONiC platforms. Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>
lguohan
approved these changes
Dec 11, 2020
Collaborator
|
retest mellanox please |
1 similar comment
Collaborator
|
retest mellanox please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default /etc/default/kdump-tools file provided by the kdump-tools
package doesn't set a value for KDUMP_CMDLINE_APPEND.
The default kdump command line arguments need to be set in order
to extend them to use additional arguments required for SONiC
platforms.
Signed-off-by: Rajendra Dendukuri rajendra.dendukuri@broadcom.com
Fixes #6113
- Why I did it
kdump-tools.service is not starting as the kdump specific command line arguments are not passed to the crash kernel
- How I did it
Specify the default KDUMP_CMDLINE_APPEND value as part of SONiC specific kdump configuration file.
- How to verify it
config kdump enable
reboot
echo c > /proc/sysrq-trigger
show kdump files
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
kdump: Add default kdump command line arguments
- A picture of a cute animal (not mandatory but encouraged)