[vmcore] Add more kernel panic conditions for vmcore dump#6095
Merged
lguohan merged 6 commits intosonic-net:masterfrom Dec 15, 2020
shlomibitton:shlomi_vmcore_support
Merged
[vmcore] Add more kernel panic conditions for vmcore dump#6095lguohan merged 6 commits intosonic-net:masterfrom shlomibitton:shlomi_vmcore_support
lguohan merged 6 commits intosonic-net:masterfrom
shlomibitton:shlomi_vmcore_support
Conversation
Add 'crashkernel=256M' to grub cmdline Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Collaborator
|
@rajendra-dendukuri , can you help to review this to see if it is align with the kdump design? |
lguohan
reviewed
Dec 3, 2020
This reverts commit 681e731.
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
rajendra-dendukuri
suggested changes
Dec 7, 2020
Collaborator
|
@rajendra-dendukuri , can you check and sign-off if possible? |
rajendra-dendukuri
approved these changes
Dec 10, 2020
lguohan
approved these changes
Dec 11, 2020
Collaborator
|
what is the proper description of this pr? it seems it add a few more conditional to instruction when to panic? Not neccessary "Allow vmcore dump in additional situations to have better debugging information." is my understanding correct? |
Contributor
Author
@lguohan I changed the description, this is more clear now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
- Why I did it
Add more kernel panic conditions to allow vmcore dump in additional situations to have better debugging information.
- How I did it
Create new file to "sysctl.d" with desired panic conditions.
It will trigger a vmcore dump using kdump-tools on these situations.
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)