[cfggen] remove get_port_config_file_name helper function#5253
Closed
vdahiya12 wants to merge 1 commit intosonic-net:masterfrom
Closed
[cfggen] remove get_port_config_file_name helper function#5253vdahiya12 wants to merge 1 commit intosonic-net:masterfrom
vdahiya12 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Contributor
|
Check builds will fail because the sonic-utilities submodule head is still referencing this function. Please open another PR to advance the sonic-utilities submodule to include your PR sonic-net/sonic-utilities#1069. Once that is merged, we can re-run the tests. |
Contributor
Author
|
closing this , code inside #5264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR addresses replacing get_port_config_file_name
function with device_info.get_path_to_port_config_file().
This is part of a larger clean up of functions which return
the port_config_file which reside outside of
sonic_py_common packages. This is motivated due to
redundancy of code as well as making it easier to change
the default behaviour of helper utility function returning
port_config_file unified in just sonic_py_common package
and in one place.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com