Skip to content

[bgpcfgd]: Clarify error message for update loopback address#5076

Merged
yxieca merged 1 commit intosonic-net:201811from
pavel-shirshov:pavelsh/bgpcfgd_error_message
Jul 31, 2020
Merged

[bgpcfgd]: Clarify error message for update loopback address#5076
yxieca merged 1 commit intosonic-net:201811from
pavel-shirshov:pavelsh/bgpcfgd_error_message

Conversation

@pavel-shirshov
Copy link
Copy Markdown
Contributor

@pavel-shirshov pavel-shirshov commented Jul 30, 2020 •
edited
Loading

- Why I did it
To make the syslog message more informative.

- How I did it
By adding current loopback ip address to the message

- How to verify it
Build new image, push into your DUT.
After that

redis-cli 
127.0.0.1:6379> select 4
OK
127.0.0.1:6379[4]> hset "LOOPBACK_INTERFACE|Loopback0|10.1.0.32/32" NULL NULL
(integer) 0
127.0.0.1:6379[4]> hset "LOOPBACK_INTERFACE|Loopback0|FC00:1::32/128" NULL NULL
(integer) 0

The syslog output would be

Last login: Thu Jul 30 16:24:17 2020 from 10.20.53.178
admin@str-s6100-acs-1:~$ sudo tail -F /var/log/syslog | grep 'bgpcfgd'
Jul 30 16:28:25.243134 str-s6100-acs-1 INFO bgp#bgpcfgd: Update command is not supported for set src templates. current ip='10.1.0.32'. new ip='10.1.0.32'
Jul 30 16:28:31.637956 str-s6100-acs-1 INFO bgp#bgpcfgd: Update command is not supported for set src templates. current ip='FC00:1::32'. new ip='FC00:1::32'

- Which release branch to backport (provide reason below if seleted)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov pavel-shirshov requested a review from yxieca July 30, 2020 16:32
@pavel-shirshov pavel-shirshov changed the title Clarify error message for bgpcfgd update loopback address [bgpcfgd]: Clarify error message for update loopback address Jul 30, 2020
@pavel-shirshov pavel-shirshov self-assigned this Jul 30, 2020
@yxieca yxieca merged commit e03ce8b into sonic-net:201811 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

@pavel-shirshov pavel-shirshov

Labels

bgp Enhancement ➕ Included in 201811 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavel-shirshov @yxieca