Skip to content

Build and install redis-dump-load Python 3 package in host image#4661

Merged
lguohan merged 8 commits intosonic-net:masterfrom
qiluo-msft:qiluo/dump3
May 30, 2020
Merged

Build and install redis-dump-load Python 3 package in host image#4661
lguohan merged 8 commits intosonic-net:masterfrom
qiluo-msft:qiluo/dump3

Conversation

@qiluo-msft
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft commented May 28, 2020

Fix #4656

Tested these cases with sonic-mellanox.bin image

  1. redis-dump (python2)
  2. python3 /usr/local/bin/redis-dump
  3. sonic-db-dump (python2)
  4. python3 /usr/local/bin/sonic-db-dump

@qiluo-msft
Copy link
Copy Markdown
Collaborator Author

@dzhangalibaba Please help review

lguohan
lguohan previously approved these changes May 28, 2020
dzhangalibaba
dzhangalibaba previously approved these changes May 28, 2020
@qiluo-msft qiluo-msft dismissed stale reviews from dzhangalibaba and lguohan via 572eb55 May 28, 2020 14:52
@qiluo-msft qiluo-msft marked this pull request as draft May 29, 2020 00:14
@qiluo-msft
Copy link
Copy Markdown
Collaborator Author

Tested these cases with sonic-mellanox.bin image

  1. redis-dump (python2)
  2. python3 /usr/local/bin/redis-dump
  3. sonic-db-dump (python2)
  4. python3 /usr/local/bin/sonic-db-dump

@qiluo-msft qiluo-msft marked this pull request as ready for review May 29, 2020 18:12
@qiluo-msft
Copy link
Copy Markdown
Collaborator Author

Retest vsimage please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 30, 2020

retest vsimage please

@lguohan lguohan merged commit 65e7a84 into sonic-net:master May 30, 2020
@qiluo-msft qiluo-msft deleted the qiluo/dump3 branch May 30, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sonic-db-dump is broken

4 participants