[sonic-yang-mgmt]: Handle dependencies in Makefile rather than setup.py#4657
Merged
lguohan merged 1 commit intosonic-net:masterfrom May 28, 2020
Merged
Conversation
…s are installed in setup.py. Changes: -- Removing the part where build dependencies are installed in setup.py. -- Adding build dependencies in corresponsing rules\..*.mk file. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
|
This pull request introduces 1 alert when merging 13f2bd3 into f0eb1db - view on LGTM.com new alerts:
|
jleveque
approved these changes
May 27, 2020
Collaborator
|
retest vsimage please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
-- Removing the part where build dependencies are installed in setup.py.
-- Adding build dependencies in corresponsing rules..*.mk file.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- Why I did it
Fix below issues reported by Joe:
- How I did it
-- Removing the part where build dependencies are installed in setup.py.
-- Adding build dependencies in corresponsing rules..*.mk file.
- How to verify it
Have to depend on JENKINS JOBS. Since Problem happens when SONIC_BUILD_JOBS=20.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)