Skip to content

[platform/cel]: Backport reboot cause API to 201811 branch#4619

Merged
lguohan merged 5 commits intosonic-net:201811from
mudsut4ke:201811_backport_reboot_cause
May 26, 2020
Merged

[platform/cel]: Backport reboot cause API to 201811 branch#4619
lguohan merged 5 commits intosonic-net:201811from
mudsut4ke:201811_backport_reboot_cause

Conversation

@mudsut4ke
Copy link
Copy Markdown
Contributor

@mudsut4ke mudsut4ke commented May 19, 2020

- Why I did it

  • Add reboot cause API to support process-reboot-cause.service

- How I did it

  • Implement chassis.get_reboot_cause platform API

- How to verify it

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented May 19, 2020

This pull request introduces 3 alerts when merging 1a340eb into 8e014bb - view on LGTM.com

new alerts:

  • 1 for Module imports itself
  • 1 for Unused import
  • 1 for Variable defined multiple times

@mudsut4ke
Copy link
Copy Markdown
Contributor Author

retest broadcom please

@mudsut4ke mudsut4ke changed the title backport rootcause api [platform/cel]: Backport reboot cause API to 201811 branch May 20, 2020
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 21, 2020

retest mellanox please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 21, 2020

retest vsimage please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 21, 2020

can you fix the lgtm alerts?

@mudsut4ke mudsut4ke marked this pull request as ready for review May 21, 2020 10:12
@mudsut4ke
Copy link
Copy Markdown
Contributor Author

can you fix the lgtm alerts?

done

Copy link
Copy Markdown
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

@mudsut4ke
Copy link
Copy Markdown
Contributor Author

@jleveque , done in afd5faa

@lguohan lguohan merged commit 9f8d691 into sonic-net:201811 May 26, 2020
@mudsut4ke mudsut4ke deleted the 201811_backport_reboot_cause branch June 9, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants