Skip to content

[platform]: Add a new supported platform, Delta-agc032#4602

Merged
lguohan merged 6 commits intosonic-net:masterfrom
zoe-kuan:master
May 27, 2020
Merged

[platform]: Add a new supported platform, Delta-agc032#4602
lguohan merged 6 commits intosonic-net:masterfrom
zoe-kuan:master

Conversation

@zoe-kuan
Copy link
Copy Markdown
Contributor

@zoe-kuan zoe-kuan commented May 15, 2020

Switch Vendor: Delta
Switch SKU: Delta-agc032
CPU: BROADWELL-DE
ASIC Vendor: Broadcom
Switch ASIC: Tomahawk3, BCM56980
Port Configuration: 32x400G + 2x10G

  • What I did
    Add a new Delta platform Delta-agc032.

  • How I did it
    Add files by following SONiC Porting Guide.

  • How to verify it

  1. decode-syseeprom
  2. sensors
  3. psuutil
  4. sfputil
  5. show interface status
  6. bcmcmd
  • Description for the changelog
    Initial commit

@zoe-kuan
[platform]: Add a new supported platform, Delta-agc032
de8f8ba 
Switch Vendor: Delta
Switch SKU: Delta-agc032
CPU: BROADWELL-DE
ASIC Vendor: Broadcom
Switch ASIC: Tomahawk3, BCM56980
Port Configuration: 32x400G + 2x10G

- What I did
Add a new Delta platform Delta-agc032.

- How I did it
Add files by following SONiC Porting Guide.

- How to verify it
1. decode-syseeprom
2. sensors
3. psuutil
4. sfputil
5. show interface status
6. bcmcmd

- Description for the changelog
Initial commit
@msftclas
Copy link
Copy Markdown

msftclas commented May 15, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented May 15, 2020

This pull request introduces 12 alerts when merging de8f8ba into d90fdbf - view on LGTM.com

new alerts:

  • 10 for Unused import
  • 2 for Unused local variable

@zoe-kuan
Fix the alerts from LGTM analysis
2cbd461 
Signed-off-by: zoe-kuan <ZOE.KUAN@deltaww.com>
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 21, 2020

can you fix the lgtm alerts?

@lguohan lguohan requested a review from jleveque May 21, 2020 03:44
@zoe-kuan
Copy link
Copy Markdown
Contributor Author

zoe-kuan commented May 21, 2020

@lguohan
Hi lgouhan,
I have already fixed the LGTM alerts and push the commit above
(commit number: 2cbd461),
and i have saw the "LGTM analysis: Python" in auto checks was successful.
Please let me know if there is any other LGTM alerts need to be fixed that i haven't noticed,
thanks.

jleveque
jleveque suggested changes May 21, 2020
View reviewed changes
@zoe-kuan
Fix inconsistent indentation.
e04b721 
Signed-off-by: zoe-kuan <ZOE.KUAN@deltaww.com>
jleveque
jleveque suggested changes May 22, 2020
View reviewed changes
platform/broadcom/sonic-platform-modules-delta/agc032/modules/delta_agc032_qsfp.c
@@ -0,0 +1,819 @@
#include <linux/device.h>
Copy link
Copy Markdown
Contributor

@jleveque jleveque May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use optoe driver rather than implementing a custom SFP driver

Copy link
Copy Markdown
Contributor Author

@zoe-kuan zoe-kuan May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confuse,
this driver is not sfp driver, this driver is used to create qsfp eeprom device node,
like "/sys/bus/i2c/devices/xx-0050",
should i rename this file?

zoe-kuan added 2 commits May 22, 2020 15:06
@zoe-kuan
Fix typo in agc032_platform_init.sh
19773a9 
Signed-off-by: zoe-kuan <ZOE.KUAN@deltaww.com>
@zoe-kuan
To revise the comment about getting syseeprom information.
73ddaf5 
Signed-off-by: zoe-kuan <ZOE.KUAN@deltaww.com>
@zoe-kuan
Copy link
Copy Markdown
Contributor Author

zoe-kuan commented May 23, 2020

@jleveque
Hi jleveque,
The check for "vsimage" was failed for my last two commits,
but the changes in these two commits was only comment revise,
i think the failed of vsimage build may not caused by my commits,
can you help to confirm this? thank you.

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented May 23, 2020

Retest vsimage please

@zoe-kuan
Copy link
Copy Markdown
Contributor Author

zoe-kuan commented May 25, 2020

Retest vsimage please

@jleveque
The build check "vsimage" is still failed, what should i do to fix that?
thanks.

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented May 25, 2020

@zoe-kuan: The vsimage failure doesn't appear to be related to your changes. I'll re-run it again.

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented May 25, 2020

Retest vsimage please

@zoe-kuan
Copy link
Copy Markdown
Contributor Author

zoe-kuan commented May 27, 2020

@jleveque:
Thanks for your help, the vsimage check was succeeded,
is there anything else need to be modified before merging commits into Azure:master branch?
please let me know, thanks.

jleveque
jleveque previously approved these changes May 27, 2020
View reviewed changes
@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented May 27, 2020

Looks good to me. I would like @lguohan to review, as well.

lguohan
lguohan reviewed May 27, 2020
View reviewed changes
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented May 27, 2020

i have a minor comment.

@zoe-kuan
Revising BCM config parameter from "serdes_tx_taps_cd.bcm56980" to "s…
b72b054 
…erdes_tx_taps_cd".

Signed-off-by: zoe-kuan <ZOE.KUAN@deltaww.com>
@lguohan lguohan merged commit fa809c8 into sonic-net:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

+1 more reviewer

@jleveque jleveque jleveque left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕ Platform: Delta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zoe-kuan @msftclas @lguohan @jleveque