Skip to content

[make reset] Also remove fsroot directory#2489

Merged
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:reset_rm_fsroot
Jan 26, 2019
Merged

[make reset] Also remove fsroot directory#2489
lguohan merged 1 commit intosonic-net:masterfrom
jleveque:reset_rm_fsroot

Conversation

@jleveque
Copy link
Copy Markdown
Contributor

@jleveque jleveque commented Jan 25, 2019

- What I did

Eliminate multiple warning: failed to remove fsroot/var/lib/dpkg/info/<filename> Permission denied warning messages when calling make reset. These messages were caused because the directory is created inside the slave Docker container by superuser, so a standard user calling make reset doesn't have proper permissions to delete the directory.

- How I did it

Now we first enter the slave Docker container and remove the fsroot directory before preforming other cleanup of the repo outside the slave Docker.

- How to verify it

Run make reset and:

  1. Ensure there are no warning: failed to remove fsroot/var/lib/dpkg/info/<filename> Permission denied warning messages
  2. After the command completes, ensure the fsroot directory was removed

@jleveque jleveque self-assigned this Jan 25, 2019
@jleveque jleveque requested review from lguohan and yxieca January 25, 2019 19:33
@lguohan lguohan merged commit d1b72fd into sonic-net:master Jan 26, 2019
@jleveque jleveque deleted the reset_rm_fsroot branch January 26, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants