[mellanox] Remove unused CRIU tool and FFB scripts#2384
Closed
stepanblyschak wants to merge 2 commits intosonic-net:masterfrom
Closed
[mellanox] Remove unused CRIU tool and FFB scripts#2384stepanblyschak wants to merge 2 commits intosonic-net:masterfrom
stepanblyschak wants to merge 2 commits intosonic-net:masterfrom
Conversation
lguohan
approved these changes
Jan 7, 2019
stcheng
approved these changes
Jan 8, 2019
added 2 commits
January 10, 2019 22:24
…nic-net#2061)" This reverts commit 514b38f. Conflicts: platform/mellanox/docker-syncd-mlnx.mk sonic-slave/Dockerfile
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
d0e11e1 to
b1fb0a5
Compare
Collaborator
Author
|
Close since is #2437 is merged and already had included this PR |
|
@stepanblyschak Can you tell me please why you decided to remove the CRIU tools? Its raw and buggy or you have another reasons? Thank you a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after #2374.
- What I did
Removed CRIU tool and parts of FFB scripts that aren't used anymore
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)