Skip to content

switch to use host syslog to for openbmp logging#22559

Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom
FengPan-Frank:syslog
May 13, 2025
Merged

switch to use host syslog to for openbmp logging#22559
qiluo-msft merged 3 commits intosonic-net:masterfrom
FengPan-Frank:syslog

Conversation

@FengPan-Frank
Copy link
Copy Markdown
Contributor

@FengPan-Frank FengPan-Frank commented May 7, 2025

Why I did it

openbmp is using dedicated logging now, which has potential log spawn issue

Work item tracking
  • Microsoft ADO (number only): 27588893

How I did it

switch to use syslog and rotate will be done together with syslog.

How to verify it

verified on device which works fine

image

image

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@FengPan-Frank FengPan-Frank requested a review from lguohan as a code owner May 7, 2025 13:15
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Copy Markdown
Contributor

/azpw ms_conflict

@FengPan-Frank FengPan-Frank requested a review from qiluo-msft May 8, 2025 07:26
@qiluo-msft
Copy link
Copy Markdown
Collaborator

@FengPan-Frank did you verify after this PR, the original log file is not created on disk? Please update PR description.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@FengPan-Frank
Copy link
Copy Markdown
Contributor Author

@FengPan-Frank did you verify after this PR, the original log file is not created on disk? Please update PR description.

Thanks, empty openbmpd.log was created but not populated, we should not need that empty file as well, updated PR.

@qiluo-msft qiluo-msft merged commit 5fc613a into sonic-net:master May 13, 2025
19 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202411: #22817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants