Skip to content

feat: add debugpy dependency#22341

Merged
wangxin merged 1 commit intosonic-net:masterfrom
auspham:austinpham/32317137-add-debugpy-dependency
Apr 28, 2025
Merged

feat: add debugpy dependency#22341
wangxin merged 1 commit intosonic-net:masterfrom
auspham:austinpham/32317137-add-debugpy-dependency

Conversation

@auspham
Copy link
Copy Markdown
Contributor

@auspham auspham commented Apr 16, 2025

Why I did it

This enable debugpy https://github.com/microsoft/debugpy as part of the dependency to support native debugging via vscode.

The follow-up PR is sonic-net/sonic-mgmt#18009 to enable in sonic-mgmt container

Work item tracking
  • Microsoft ADO (number only): 32317137

How I did it

Add debugpy as part of pip library

How to verify it

Verified on dev-vm:

make -f Makefile.work BLDENV=bullseye SONIC_BUILD_JOBS=$(nproc) DEFAULT_CONTAINER_REGISTRY=publicmirror.azurecr.io ENABLE_DOCKER_BASE_PULL=y LEGACY_SONIC_MGMT_DOCKER=y target/docker-sonic-mgmt.gz

docker load -i target/docker-sonic-mgmt.gz

docker run -it --rm docker-sonic-mgmt:latest debugpy 

debugpy 1.8.14
See https://aka.ms/debugpy for documentation.

Usage: debugpy --listen | --connect
               [<host>:]<port>
               [--wait-for-client]
               [--configure-<name> <value>]...
               [--log-to <path>] [--log-to-stderr]
               <filename> | -m <module> | -c <code> | --pid <pid>
               [<arg>]...

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@auspham
feat: add debugpy dependency
4fd8da1 
Signed-off-by: Austin Pham <austinpham@microsoft.com>
@auspham auspham requested a review from lguohan as a code owner April 16, 2025 07:53
@auspham auspham mentioned this pull request Apr 16, 2025
Merged
11 tasks
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 16, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Apr 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

yejianquan
yejianquan approved these changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auspham auspham requested a review from wangxin April 28, 2025 06:14
@wangxin wangxin merged commit 8d6fe0c into sonic-net:master Apr 28, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxin wangxin wangxin approved these changes

@yejianquan yejianquan yejianquan approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auspham @mssonicbld @wangxin @yejianquan