[build]: add build option to use native docker instead of dind for build#2215
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 2, 2018
Merged
[build]: add build option to use native docker instead of dind for build#2215lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
using native docker is faster than dind dockerd with vfs storage driver sonic-net#2016 Azure/draft#181 Signed-off-by: Wataru Ishida <ishida@nel-america.com>
9d08289 to
5196161
Compare
Collaborator
|
How much faster? Do you have data? |
Collaborator
Author
|
I have very rough numbers. dind: 2h23min, native: 1h45min I'm not sure I measured with the exact same cache status. |
Collaborator
|
what is the down side of this option? should this be the build default option? |
Collaborator
Author
|
the dockerd running in the host needs to be executed with |
Collaborator
|
which experimental feature in the docker are you using? |
Collaborator
Author
|
|
lguohan
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wataru Ishida ishida@nel-america.com
- What I did
Add a build option to use native dockerd instead of dind for faster build.
related PR : #2016
Also, I found an issue pointing out the slowness of
vfsstorage driver.It seems they fixed it by changing the driver to
overlay.Azure/draft#181
- How I did it
mount /var/run/docker.sock in build container
- How to verify it
Add following to
rules/config- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)