Install netaddr 0.10.1 in the Python 2 part of sonic-mgmt#18094
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 14, 2024
Merged
Install netaddr 0.10.1 in the Python 2 part of sonic-mgmt#18094yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Recently, netaddr 1.0.0 was released, which dropped Python 2 support entirely. Because of this, an empty netaddr package is installed for Python 2. Ansible still uses Python 2, so this needs to remain functional. The Python 3 part of sonic-mgmt is fine. Pin the version of netaddr installed in Python 2 to 0.10.1, the last supported version. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
yxieca
approved these changes
Feb 14, 2024
Contributor
|
This PR needs to be forcefully merged so that new sonic-mgmt docker could be built to unblock the other PR tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Recently, netaddr 1.0.0 was released, which dropped Python 2 support entirely. Because of this, an empty netaddr package is installed for Python 2. Ansible still uses Python 2, so this needs to remain functional. The Python 3 part of sonic-mgmt is fine.
Work item tracking
How I did it
Pin the version of netaddr installed in Python 2 to 0.10.1, the last supported version.
How to verify it
Installed netaddr 0.10.1 in the latest sonic-mgmt container, and verified it can now be imported in Python 2.
Also verified from the docker-sonic-mgmt that was built as part of the PR checks that netaddr can be imported in Python 2.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)