Skip to content

Debug dump utility HLD#789

Merged
liat-grozovik merged 23 commits intosonic-net:masterfrom
vivekrnv:debug_dump_utility
Jul 6, 2021
Merged

Debug dump utility HLD#789
liat-grozovik merged 23 commits intosonic-net:masterfrom
vivekrnv:debug_dump_utility

Conversation

@vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented May 17, 2021

@gechiang gechiang requested a review from SuvarnaMeenakshi May 18, 2021 15:27
@gechiang
Copy link
Contributor

@SuvarnaMeenakshi Can you help clarify if VS for multi-asic support is available so that @vivekreddynv can add the support of this utilities for multi-asic?
Thanks!

@SuvarnaMeenakshi
Copy link
Contributor

@SuvarnaMeenakshi Can you help clarify if VS for multi-asic support is available so that @vivekreddynv can add the support of this utilities for multi-asic?
Thanks!
for master branch, this PR is required to bring up multi-asic vs: sonic-net/sonic-buildimage#7632
PR verification steps have information on how to bring up a multi-asic vs testbed.
Also, swss docker does not come up currently, I am debugging that part currently.
To workaround, this diff can be used for now: SuvarnaMeenakshi/sonic-buildimage@f7f6260

@vivekrnv
Copy link
Contributor Author

@gechiang I've added "--namespace / -n" option to the dump state CLI. I'm using SonicV2Connector to connect to the Redis Underneath and i've made sure that this argument is propagated down to the connector level. I've also added the Multi-ASIC UT's in the sonic-utilities directory and made sure the change is working as expected.

However, i couldn't test this feature on actual hardware or on a VS Image currently. I'll try my best to test this on a VS image once the issues mentioned by @SuvarnaMeenakshi are merged and also when i find some buffer.

If you wish to verify the functionality on a multi-asic platform, i can send the code tarball and instructions or a binary built with these changes to test the feature

@liat-grozovik
Copy link
Collaborator

@lguohan can you please assign a reviewer to approve this HLD?
PRs should come by EOW and HLD should be closed before it. Thanks.

@SuvarnaMeenakshi
Copy link
Contributor

@gechiang I've added "--namespace / -n" option to the dump state CLI. I'm using SonicV2Connector to connect to the Redis Underneath and i've made sure that this argument is propagated down to the connector level. I've also added the Multi-ASIC UT's in the sonic-utilities directory and made sure the change is working as expected.

However, i couldn't test this feature on actual hardware or on a VS Image currently. I'll try my best to test this on a VS image once the issues mentioned by @SuvarnaMeenakshi are merged and also when i find some buffer.

If you wish to verify the functionality on a multi-asic platform, i can send the code tarball and instructions or a binary built with these changes to test the feature

You could use the latest master branch to bring up multi-asic Virtual swith, the required changes are in place.
https://github.com/Azure/sonic-buildimage/blob/master/platform/vs/README.vsvm.md - Reference.

@liat-grozovik
Copy link
Collaborator

@SuvarnaMeenakshi kindly reminder to review recent updates

Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liat-grozovik liat-grozovik merged commit 350cebd into sonic-net:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants