Merged
Conversation
Merged
8f9a4d3 to
d093b41
Compare
tahmed-dev
previously approved these changes
Jun 29, 2021
tahmed-dev
left a comment
There was a problem hiding this comment.
LGTM, few minor comments. Thanks for your work.
lguohan
reviewed
Jul 1, 2021
|
|
||
| # Overview | ||
|
|
||
| SONiC currently supports DHCPv4 Relay via the use of open source ISC DHCP package. However, DHCPv6 specification does not define a way to communicate client link-layer address to the DHCP server where DHCP server is not connected to the same network link as DHCP client. DHCPv6 requires all clients prepare and send a DUID as the client identifier in all DHCPv6 message exchanges. However, these methods do not provide a simple way to extract a client's link-layer address. Providing option 79 in DHCPv6 Relay-Forward messages will help carry the client link-layer address explicitly. The server needs to know the client's MAC address to allow DHCP Reservation, which provides pre-set IP address to specific client based on its physical MAC address. The DHCPv6 relay agent is able to read the source MAC address of DHCPv6 messages that it received from client, and encapsulate these messages within a DHCPv6 Relay-Forward message, inserting the client MAC address as option 79 in the Relay-Forward header sent to the server. |
Collaborator
There was a problem hiding this comment.
Please add details on why we think opensource ISC package is not a right fit for this DHCP6 relay enhancements.
lguohan
reviewed
Jul 21, 2021
| 3. Request, Renew, Rebind: DHCPv6 client sends a REQUEST message to request configuration parameters(IP address or delegated prefixes) from the DHCPv6 server | ||
| 4. Reply: DHCPv6 server sends a REPLY message containing assigned addresses and configuration parameters in response to a CONFIRM message that confirms or denies that the addresses assigned to the client are appropriate to the link to which the client is connected. REPLY message acknowledges receipt of a RELEASE or DECLINE message. | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
please upload the image to this folder images directory.
lguohan
reviewed
Jul 21, 2021
| type inet6:ip-address; | ||
| } | ||
| leaf options { | ||
| type uint16; |
Contributor
There was a problem hiding this comment.
does this only allow one option, what if we have other options? I suggest to define option79 true/false. some options needs parameter. it is difficult to define a universal way to define options.
Contributor
Author
There was a problem hiding this comment.
Updated option 79 to have a bool type! Future options added can define its own parameter.
5 tasks
…into kellyyeh-dhcprelay
tahmed-dev
reviewed
Jul 30, 2021
tahmed-dev
approved these changes
Aug 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.