[xcvrd design] robust enhancement to xcvrd design#228
Merged
keboliu merged 4 commits intosonic-net:gh-pagesfrom Aug 22, 2018
keboliu:xcvrd-hld
Merged
[xcvrd design] robust enhancement to xcvrd design#228keboliu merged 4 commits intosonic-net:gh-pagesfrom keboliu:xcvrd-hld
keboliu merged 4 commits intosonic-net:gh-pagesfrom
keboliu:xcvrd-hld
Conversation
qiluo-msft
reviewed
Aug 8, 2018
|
|
||
| It's possible that when received the plug in/out event, the transceiver eeprom is not ready for reading, so need to give another try if first reading failed. | ||
|
|
||
| #### 1.3.1 Transceiver plug in/out event implementation on mlnx platform #### |
Contributor
There was a problem hiding this comment.
In above section, "default value 0 means never timeout" is not good. A blocking function with timeout zero normally means no wait at all.
qiluo-msft
reviewed
Aug 8, 2018
doc/transceiver-monitor-hld.md
Outdated
| 1. not able to get correct sfp change event from SDK | ||
| 2. mlnx-sfpd itself failed for some reason. | ||
|
|
||
| mlnx-sfpd will periodically write a timestamp to STATE_DB to show the liveness. On above two failure cases mlnx-sfpd will stop update the timestamp and exit. Related info will be logged as error indication to user. |
Contributor
There was a problem hiding this comment.
Using timestamp is implementation details, not part of the design. I encourage you investigate another alternative implementation https://redis.io/commands/expire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a robust enhancement design for xcvrd on mlnx platform