Skip to content

HLD for PNAC feature introduction in SONiC#1292

Closed
kishorgovind wants to merge 69 commits intosonic-net:masterfrom
kishorgovind:master
Closed

HLD for PNAC feature introduction in SONiC#1292
kishorgovind wants to merge 69 commits intosonic-net:masterfrom
kishorgovind:master

Conversation

@kishorgovind
Copy link

This document describes the high-level design of PNAC (Port Network Access Control) feature in SONiC.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2023

@venkatmahalingam
Copy link
Collaborator

venkatmahalingam commented Apr 11, 2023

Looks like there is an HLD from BRCM to support the same PNAC features + MAB
#1315

IMO, we should compare and converge on what's best for the community.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide config flow for both un-authorized and authorized states.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this table a part of CONFIG_DB? This seems like an operational change again w.r.t PNAC.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. We will update this topic.

Copy link
Collaborator

@zhangyanzhao zhangyanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishorgovind can you please help to provide the code PRs? Thanks.

@zhangyanzhao
Copy link
Collaborator

Please add the code PRs if you have. Thanks

@thovikeerthi
Copy link
Contributor

Please add the code PRs if you have. Thanks

Code Pull Request IDs:
sonic-buildimage repository : sonic-net/sonic-buildimage#15332
sonic-swss repository : sonic-net/sonic-swss#2809
sonic-utilities repository : sonic-net/sonic-utilities#2859

@msosyak
Copy link

msosyak commented Aug 8, 2023

@kishorgovind Did I understand correctly that community desided to go with #1315 with farther extention with local autentification? If yes, is this PR and related Code PRs still relevant or they should be closed?

@kishorgovind kishorgovind closed this by deleting the head repository Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants