Skip to content

[BUG] - Allow only songs from this playlist not working correctly #170

@MoFroGT

Description

@MoFroGT

Songify Version
v1.7.2.0

Describe the bug
There is a bug in Songify Slim/Util/Songify/TwitchHandler.cs in the CheckIsSongAllowed method
It checks against Settings.Settings.SpotifyPlaylistId
It should be checking against Settings.Settings.SpotifySongLimitPlaylist

This bug makes it so that the "Allow only songs from this playlist (SR)" setting does not work correctly unless the chosen playlist matches the "Liked Songs Playlist" setting. Any song requests will fail if the two do not match.

To Reproduce
Steps to reproduce the behavior:

  1. Set "Liked Songs Playlist" to empty or a playlist
  2. Set "Allow only songs from this playlist (SR)" to a different playlist
  3. Attempt to request a song through Twitch from the playlist set as "Allow only songs from this playlist (SR)"
  4. Observe that the song request fails

Expected behavior
Both settings should work independently from one another.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions