Merged
Conversation
🦋 Changeset detectedLatest commit: 2bc5802 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Closed
edemaine
reviewed
Feb 19, 2025
edemaine
left a comment
There was a problem hiding this comment.
Nice, that is an even simpler fix than my PR.
I'm hoping one of these, or a similar fix, gets merged. I'm glad to hear there are more settings where query strings are common and it's not just Civet. Solid is usually very fast to get updated, so fingers crossed...
birkskyum
approved these changes
Feb 19, 2025
Member
|
Checked the solid-start test suites, and they passes with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading files in tanstack solid router it can add a ?tsr-split=component to the filename which our plugin skips because of the query string.
I moved up the replace of the query string up higher so that it doesn't filter it out a couple lines below.