This repository was archived by the owner on Jul 6, 2020. It is now read-only.
Fix invalid header link from #44 #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjetilk
approved these changes
Apr 3, 2019
Contributor
kjetilk
left a comment
There was a problem hiding this comment.
Yeah, this seems to be needed indeed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mitzi-Laszlo This should fix the master branch. The reason travis didn't catch this is because travis only runs on pull requests from when it was enabled. All of the current PRs except #87 were created before kietilk enabled travis on Mon afternoon so for those PRs you won't know if there are invalid links until they are merged to master. Starting with #87, PRs will have a pass/fail indicator for the travis build. I would recommend merging this soon so that future PRs (and #87) don't fail