Make resource creation more exact and testable #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
csarven
requested changes
May 12, 2021
Member
csarven
left a comment
There was a problem hiding this comment.
I think mention of client can be omitted altogether. Also focus on effective request URI.
Changing the requirement's focus (from clients) to servers is perhaps most useful for PATCH because it changes resource creation from MAY (RFC5789) to MUST. For PUT and POST, the requirement is actually not needed because it is already covered by RFC 7231.
Co-authored-by: Sarven Capadisli <info@csarven.ca>
Co-authored-by: Sarven Capadisli <info@csarven.ca>
Member
|
Should we still guide (informative/note) the clients along the lines of: Clients can use PUT and PATCH requests to assign a URI to a resource. Clients can use POST requests to have the server assign a URI to a resource. |
Member
|
Added commit. Have a look. Interesting that GitHub doesn't allow me to request a review from you (sort of obviously). |
csarven
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.